Case-map an astral first letter in ToCamelCase and the first-char helpers - #76
Merged
Merged
Conversation
…pers ToLowercaseFirstChar and ToUppercaseFirstChar case-mapped input[0], which for a letter outside the Basic Multilingual Plane is only the high surrogate, so the letter came back unchanged. ToCamelCase goes through ToLowercaseFirstChar and inherited this. Map the first code point instead, using the CodePointLength helper the other conversions already rely on. Fixes #74 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018AEYBNCRr6chFLiZDv1MVj
|
This was referenced Sep 26, 2026
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74
What was wrong
ToLowercaseFirstCharandToUppercaseFirstCharcase-mappedinput[0]. For a letter outside the Basic Multilingual Plane (e.g. Deseret𐐀U+10400 ↔𐐨U+10428),input[0]is only the high surrogate, so the letter came back unchanged.ToCamelCasegoes throughToLowercaseFirstChar, so"𐐀abc".ToCamelCase()returned𐐀abc, the same asToPascalCase. #70 had already fixed this for every other conversion.Change
MapFirstCodePointhelper. It takes the first code point (via the existingCodePointLength), maps it, and appends the rest. Both first-char helpers now use it, which also replaces their duplicated#if NETSTANDARD2_0branches."XX foo"→"xxFoo").Verification
dotnet test: 38/38 pass.dotnet build CaseConverter/CaseConverter.csprojsucceeds for every target framework, including netstandard2.0, with no warnings.🤖 Generated with Claude Code
https://claude.ai/code/session_018AEYBNCRr6chFLiZDv1MVj
Generated by Claude Code