GitHubRequestOutcomeTests fail with NullReferenceException on main: #288's tests build an Owner with no BuildProvider after #285

[matt-edmondson]

What's wrong

4 tests in BuildMonitor.Test/GitHubRequestOutcomeTests.cs fail on main with NullReferenceException on every platform:

• the OwnerWithToken helper at line 130, and the tests that use it
• AWorkflowActionWithoutCredentialsReportsFailureWithoutCalling at line 192

Cause

These tests construct new Owner { ... } without a BuildProvider. Since #285 moved tokens into the secret store, Owner.TokenPersona dereferences BuildProvider.Name, so reading or writing the owner's token throws. #288 (which added these tests) was written before #285, and the two were merged in an order that broke them (80806f3 then b672d07).

Why it matters

The request-outcome reporting that #288 added is currently untested, and a red test suite on main hides new regressions.

Suggested fix / acceptance criteria

• Build owners with provider.CreateOwner(...) so BuildProvider is set.
• Inject an in-memory store via TokenStorage.UseCache so the tests don't touch the OS secret store.
• dotnet test passes for GitHubRequestOutcomeTests on Windows and Linux.

[matt-edmondson]

Triage

• Category: Bug (a test regression caused by merge order)
• Priority: High. main is red on every platform. That leaves the request-outcome reporting from fix: report a workflow action that the GitHub API refused as failed [patch] #288 untested and hides any new regression behind existing failures. The fix is test-only and small.
• Area / suggested assignee: The test setup in BuildMonitor.Test/GitHubRequestOutcomeTests.cs. Maintainer: @matt-edmondson.
• Duplicates / in progress: No duplicate and no open fix PR. Open PR Bump the ktsu group with 18 updates #295 (dependency bump) will run CI against this red suite, so land this fix first. On Linux, On Linux without libsecret, every token read throws TypeInitializationException instead of reading as empty #296 adds more failures on top of these.
• Next steps: Build owners through provider.CreateOwner(...), inject an in-memory store via TokenStorage.UseCache, and confirm dotnet test passes on Windows and Linux.

---

Generated by Claude Code