Skip to content

feat: migrated common frontend and backend from notebooks v1 - #203

Open
LogicalGuy77 wants to merge 3 commits into
kserve:masterfrom
LogicalGuy77:common-lib-migration
Open

feat: migrated common frontend and backend from notebooks v1#203
LogicalGuy77 wants to merge 3 commits into
kserve:masterfrom
LogicalGuy77:common-lib-migration

Conversation

@LogicalGuy77

@LogicalGuy77 LogicalGuy77 commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Models Web Application can now build without cloning Kubeflow Notebooks.

Key changes:

  • Added all 289 pinned common-library files under common/, with provenance documented in common/README.md.
  • Rewired Dockerfile to build both libraries locally; Git and Notebooks stages are gone.
  • Updated local development through frontend/Makefile, backend/Makefile, and README.md.
  • Rewired test-node.yaml and added both lockfiles to caching.
  • Deleted frontend/COMMIT.
  • Expanded .dockerignore to exclude generated artifacts and large Angular caches.
  • Did not modify Notebooks, manifests, package versions, imports, or runtime interfaces.

Verification completed:

  • Byte-for-byte equality: 34 backend and 255 frontend files.
  • Common Angular library builds under Node 16 and the Docker build runtime.
  • Frontend: 32 Jest suites, 205 tests passed.
  • Cypress: 9 specs, 65 tests passed.
  • Prettier and Angular lint passed.
  • Backend: wheel/sdist build, installation/import, and 17 existing tests passed.
  • Clean-context OCI build passed; final image contains kubeflow 1.2, compiled frontend assets, and no Git executable.
  • No stale Notebooks checkout variables/instructions or manifest changes.
  • No generated artifacts remain under common/

fixes: #202

@LogicalGuy77
feat: migrated common frontend and backend from notebooks v1
e6511ef 
Signed-off-by: Harshit Nayan <harshitacademia@gmail.com>
@LogicalGuy77
Root .gitignore had **/fonts/, which excluded the 21 vendored assets/…
ad1b79c 
…fonts/*.woff2 files. copyAssets then failed on a clean checkout (cp: cannot stat './projects/kubeflow/src/assets'), breaking both frontend CI jobs and the OCI build. Scoped the ignore to the generated frontend/src/assets/fonts/ and committed the fonts.

Signed-off-by: Harshit Nayan <harshitacademia@gmail.com>
@juliusvonkohout
juliusvonkohout requested a balanced review from Copilot September 4, 2026 07:07
Copilot AI reviewed Sep 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

CI coverage for the migrated frontend library and stale local build handling must be fixed before approval.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Migrates pinned Kubeflow common frontend and backend libraries into this repository, enabling standalone local and container builds.

Changes:

  • Vendors the common Angular and Python libraries with provenance.
  • Rewires Docker and development workflows to use local sources.
  • Removes the external Notebooks revision pin and updates ignored artifacts.

Required fixes:

  • Moderate (2 votes): .github/workflows/test-node.yaml:46 must run the migrated library’s tests, formatter, and linter in CI.
  • Moderate (1 vote): frontend/Makefile:14 must prevent setup from linking stale common-library build output.
File summaries
File Summary
Makefile Updates build orchestration.
frontend/Makefile Builds and links the local frontend library.
frontend/COMMIT Removes the obsolete external revision pin.
Dockerfile Builds common libraries locally.
common/README.md Documents provenance and ownership.
common/frontend/kubeflow-common-lib/tsconfig.json Migrates frontend configuration.
common/frontend/kubeflow-common-lib/scripts/check-format-error.js Migrates formatting helper.
common/frontend/kubeflow-common-lib/README.md Migrates frontend documentation.
common/frontend/kubeflow-common-lib/projects/kubeflow/tsconfig.spec.json Migrates test configuration.
common/frontend/kubeflow-common-lib/projects/kubeflow/tsconfig.lib.prod.json Migrates production configuration.
common/frontend/kubeflow-common-lib/projects/kubeflow/tsconfig.lib.json Migrates library configuration.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/test.ts Migrates test bootstrap.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/styles/variables.scss Migrates shared styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/styles/kubeflow.css Migrates shared styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/variables-groups-table/variables-groups-table.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/variables-groups-table/variables-groups-table.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/variables-groups-table/variables-groups-table.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/variables-groups-table/variables-groups-table.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/variables-groups-table/variables-groups-table.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/variables-groups-table/types.ts Migrates frontend types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/utils/kubernetes.ts Migrates Kubernetes utilities.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/utils/kubernetes.model.ts Migrates Kubernetes models.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/urls/urls.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/urls/urls.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/urls/urls.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/urls/urls.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/urls/urls.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/urls/types.ts Migrates frontend types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/title-actions-toolbar/types.ts Migrates frontend types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/title-actions-toolbar/title-actions-toolbar.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/title-actions-toolbar/title-actions-toolbar.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/title-actions-toolbar/title-actions-toolbar.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/title-actions-toolbar/title-actions-toolbar.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/title-actions-toolbar/title-actions-toolbar.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/status-info/status-info.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/status-info/status-info.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/status-info/status-info.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/status-info/status-info.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/status-info/status-info.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/status-icon/status-icon.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/status-icon/status-icon.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/status-icon/status-icon.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/status-icon/status-icon.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/status-icon/status-icon.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/snack-bar/types.ts Migrates frontend types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/snack-bar/snack-bar.service.ts Migrates Angular service.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/snack-bar/snack-bar.service.spec.ts Migrates service test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/snack-bar/snack-bar.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/snack-bar/component/snack-bar.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/snack-bar/component/snack-bar.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/snack-bar/component/snack-bar.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/snack-bar/component/snack-bar.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/services/poller.service.ts Migrates Angular service.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/services/poller.service.spec.ts Migrates service test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/services/namespace.service.spec.ts Migrates service test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/services/frontend/editor-loader.service.ts Migrates Angular service.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/services/date-time.service.spec.ts Migrates service test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/services/backend/types.ts Migrates backend-response types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/services/backend/backend.service.spec.ts Migrates service test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/types/template.ts Migrates table types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/types/table.ts Migrates table types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/types/menu-value.ts Migrates table types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/types/memory-value.ts Migrates table types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/types/index.ts Migrates table type exports.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/types/date-time.ts Migrates table types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/types/component-value.ts Migrates table types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/types/chip-list.ts Migrates table types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/types/action.ts Migrates table types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/types/action-icon-value.ts Migrates table types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/types/action-button.ts Migrates table types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/table/table.component.scss Migrates table styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/status/types.ts Migrates status types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/status/status.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/status/status.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/status/status.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/status/status.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/resource-table.component.scss Migrates table styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/component-value/component-value.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/component-value/component-value.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/component-value/component-value.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/chips-list/chips-list.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/chips-list/chips-list.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/chips-list/chips-list.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/action/action.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/action/action.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/action/action.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/action-button/action-button.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/action-button/action-button.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/action-button/action-button.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/action-button/action-button.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/popover/popover.scss Migrates popover styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/popover/popover.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/popover/popover.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/panel/panel.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/panel/panel.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/panel/panel.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/panel/panel.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/panel/panel.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/namespace-select/namespace-select.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/namespace-select/namespace-select.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/namespace-select/namespace-select.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/namespace-select/namespace-select.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/namespace-select/namespace-select.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/logs-viewer/logs-viewer.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/logs-viewer/logs-viewer.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/logs-viewer/logs-viewer.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/logs-viewer/logs-viewer.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/logs-viewer/logs-viewer.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/loading-spinner/loading-spinner.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/loading-spinner/loading-spinner.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/loading-spinner/loading-spinner.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/loading-spinner/loading-spinner.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/loading-spinner/loading-spinner.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/kubeflow.module.ts Migrates aggregate Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/icon/icon.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/icon/icon.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/icon/icon.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/icon/icon.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/icon/icon.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/help-popover/help-popover.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/help-popover/help-popover.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/help-popover/help-popover.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/help-popover/help-popover.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/heading-subheading-row/heading-subheading-row.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/heading-subheading-row/heading-subheading-row.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/heading-subheading-row/heading-subheading-row.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/heading-subheading-row/heading-subheading-row.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/heading-subheading-row/heading-subheading-row.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/utils.ts Migrates form utilities.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/submit-bar/submit-bar.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/submit-bar/submit-bar.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/submit-bar/submit-bar.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/submit-bar/submit-bar.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/step-info/step-info.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/step-info/step-info.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/step-info/step-info.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/step-info/step-info.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/section/section.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/section/section.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/section/section.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/section/section.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/positive-number-input/positive-number-input.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/positive-number-input/positive-number-input.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/positive-number-input/positive-number-input.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/positive-number-input/positive-number-input.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/name-namespace-inputs/name-namespace-inputs.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/name-namespace-inputs/name-namespace-inputs.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/name-namespace-inputs/name-namespace-inputs.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/name-namespace-inputs/name-namespace-inputs.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/name-namespace-inputs/name-input/name-input.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/name-namespace-inputs/name-input/name-input.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/name-namespace-inputs/name-input/name-input.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/name-namespace-inputs/name-input/name-input.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/error-state-matcher.ts Migrates form error handling.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/advanced-options/advanced-options.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/advanced-options/advanced-options.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/advanced-options/advanced-options.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/advanced-options/advanced-options.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/form/advanced-options/advanced-options.component.css Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/enums/dashboard.ts Migrates dashboard enums.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/editor/README.md Migrates editor documentation.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/editor/editor.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/editor/editor.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/editor/editor.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/editor/editor.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/details-list/types.ts Migrates frontend types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/details-list/details-list.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/details-list/details-list.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/details-list/details-list.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/details-list/details-list.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/details-list/details-list.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/details-list/details-list-item/details-list-item.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/details-list/details-list-item/details-list-item.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/date-time/to-date.pipe.ts Migrates date conversion pipe.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/date-time/date-time.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/date-time/date-time.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/date-time/date-time.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/content-list-item/content-list-item.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/content-list-item/content-list-item.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/content-list-item/content-list-item.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/content-list-item/content-list-item.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/content-list-item/content-list-item.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/confirm-dialog/types.ts Migrates frontend types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/confirm-dialog/dialog/dialog.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/confirm-dialog/dialog/dialog.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/confirm-dialog/dialog/dialog.component.scss Migrates component styles.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/confirm-dialog/dialog/dialog.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/confirm-dialog/confirm-dialog.service.ts Migrates Angular service.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/confirm-dialog/confirm-dialog.service.spec.ts Migrates service test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/confirm-dialog/confirm-dialog.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/conditions-table/types.ts Migrates frontend types.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/conditions-table/config.ts Migrates table configuration.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/conditions-table/conditions-table.module.ts Migrates Angular module.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/conditions-table/conditions-table.component.ts Migrates Angular component.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/conditions-table/conditions-table.component.spec.ts Migrates Angular test.
common/frontend/kubeflow-common-lib/projects/kubeflow/src/lib/conditions-table/conditions-table.component.html Migrates component template.
common/frontend/kubeflow-common-lib/projects/kubeflow/README.md Migrates project documentation.
common/frontend/kubeflow-common-lib/projects/kubeflow/package.json Migrates package metadata.
common/frontend/kubeflow-common-lib/projects/kubeflow/package-lock.json Pins project dependencies.
common/frontend/kubeflow-common-lib/projects/kubeflow/ng-package.json Migrates packaging configuration.
common/frontend/kubeflow-common-lib/projects/kubeflow/karma.conf.js Migrates test-runner configuration.
common/frontend/kubeflow-common-lib/projects/kubeflow/.prettierrc Migrates formatting configuration.
common/frontend/kubeflow-common-lib/projects/kubeflow/.eslintrc.json Migrates lint configuration.
common/frontend/kubeflow-common-lib/angular.json Migrates Angular workspace configuration.
common/frontend/kubeflow-common-lib/.gitignore Excludes frontend artifacts.
common/frontend/kubeflow-common-lib/.eslintrc.json Migrates root lint configuration.
common/frontend/kubeflow-common-lib/.editorconfig Migrates editor configuration.
common/backend/setup.py Migrates Python package metadata.
common/backend/kubeflow/kubeflow/crud_backend/status.py Migrates backend status definitions.
common/backend/kubeflow/kubeflow/crud_backend/settings.py Migrates backend settings.
common/backend/kubeflow/kubeflow/crud_backend/serving.py Migrates frontend serving support.
common/backend/kubeflow/kubeflow/crud_backend/routes/get.py Migrates common GET routes.
common/backend/kubeflow/kubeflow/crud_backend/routes/__init__.py Migrates route registration.
common/backend/kubeflow/kubeflow/crud_backend/probes.py Migrates health probes.
common/backend/kubeflow/kubeflow/crud_backend/metrics.py Migrates metrics support.
common/backend/kubeflow/kubeflow/crud_backend/errors/utils.py Migrates error utilities.
common/backend/kubeflow/kubeflow/crud_backend/errors/handlers.py Migrates error handlers.
common/backend/kubeflow/kubeflow/crud_backend/errors/__init__.py Migrates error exports.
common/backend/kubeflow/kubeflow/crud_backend/decorators.py Migrates request decorators.
common/backend/kubeflow/kubeflow/crud_backend/config.py Migrates backend configuration.
common/backend/kubeflow/kubeflow/crud_backend/authn.py Migrates authentication handling.
common/backend/kubeflow/kubeflow/crud_backend/api/utils.py Migrates API utilities.
common/backend/kubeflow/kubeflow/crud_backend/api/storageclass.py Migrates storage-class operations.
common/backend/kubeflow/kubeflow/crud_backend/api/secret.py Migrates secret operations.
common/backend/kubeflow/kubeflow/crud_backend/api/pvc.py Migrates persistent-volume operations.
common/backend/kubeflow/kubeflow/crud_backend/api/poddefault.py Migrates PodDefault operations.
common/backend/kubeflow/kubeflow/crud_backend/api/pod.py Migrates pod operations.
common/backend/kubeflow/kubeflow/crud_backend/api/notebook.py Migrates notebook operations.
common/backend/kubeflow/kubeflow/crud_backend/api/node.py Migrates node operations.
common/backend/kubeflow/kubeflow/crud_backend/api/namespace.py Migrates namespace operations.
common/backend/kubeflow/kubeflow/crud_backend/api/events.py Migrates event operations.
common/backend/kubeflow/kubeflow/crud_backend/api/custom_resource.py Migrates custom-resource operations.
common/backend/kubeflow/kubeflow/crud_backend/api/apis.py Migrates Kubernetes API clients.
common/backend/kubeflow/kubeflow/crud_backend/api/__init__.py Migrates API exports.
common/backend/kubeflow/kubeflow/crud_backend/__init__.py Migrates application initialization.
common/backend/kubeflow/kubeflow/__init__.py Migrates package initialization.
common/backend/kubeflow/__init__.py Migrates package initialization.
common/backend/.gitignore Excludes Python build artifacts.
backend/Makefile Installs the local common backend.
.gitignore Updates generated-artifact exclusions.
.dockerignore Excludes generated and cache artifacts.
Review details

Files not reviewed (1)

  • common/frontend/kubeflow-common-lib/projects/kubeflow/package-lock.json: Generated file

Suppressed comments (1)

frontend/Makefile:18

  • setup treats any existing dist/kubeflow directory as current, so after pulling or editing the newly vendored common library it silently keeps linking stale output. Since that directory is ignored and clean does not remove it, rebuild the local library on every setup (or add a dependency-aware rebuild) so local development actually reflects the checked-in source.
  • Files reviewed: 265/299 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/test-node.yaml
@LogicalGuy77
feat: enhance CI workflow for common library checks and streamline fr…
af97371 
…ontend setup

Signed-off-by: Harshit Nayan <harshitacademia@gmail.com>
@juliusvonkohout
juliusvonkohout requested a balanced review from Copilot September 5, 2026 21:03
Copilot AI reviewed Sep 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Critical licensing documentation and stale frontend asset handling remain unresolved.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Files not reviewed (1)

  • common/frontend/kubeflow-common-lib/projects/kubeflow/package-lock.json: Generated file
  • Files reviewed: 265/299 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment thread common/README.md
Comment on lines +16 to +17
The upstream source is provided under the Apache License 2.0. Future changes to
these libraries are owned and reviewed in the KServe Models Web Application
Comment thread frontend/Makefile
Comment on lines +14 to +17
@echo ">> Building kubeflow-common-library"
@cd "$(COMMON_LIBRARY_DIRECTORY)" && \
npm install && \
npm run build; \
else \
echo ">> Kubeflow library already built"; \
fi
npm run build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move common frontend and backend from notebooks to models web application

2 participants

@LogicalGuy77