Pin the Rust toolchain and fix new clippy 1.97 lints#613
Open
NicolasBuchin wants to merge 1 commit into
Open
Conversation
The CI pipeline installed the latest rustup stable shipped, so a clippy release could suddenly fail on branches. Rust 1.97 did that on main, so any push commit would fail the CI test. We were still using clippy 1.91. Here we pin the toolchain in rust-toolchain.toml, so the CI matches our local tests. We also fix the lints for 1.97.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix to match our toolchain version and the CI's. It fixes the version in
rust-toolchain.toml, and I set it to the latest 1.97 (currently in the CI).I also went ahead and fixed main to match clippy 1.97 rules. Feel free to use an older version of the toolchain if you don't want the small changes in the code.
Since the clippy warnings are found in main, no commit will pass the CI until this is resolved.