fix(worker): release pending handlers after errors - #838
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Release pending-call handlers after worker failures.
postMessagethrows synchronously, such as aDataCloneError. The Promise already rejects in this case, but the map currently retains its resolve/reject closures.Before this change, a clone failure leaves one settled entry retained; two pending calls followed by a worker error leave two. Repeated failures accumulate these entries until termination or a reply that may never arrive.
No changes to search scoring, ranking, options, worker-error rejection scope, or public APIs. No breaking changes. This fixes cleanup only; it does not add worker restart/recovery behavior.
Verification
git diff --checkpass.structuredClonevalidation; no real-browser worker lifecycle testing is claimed.