feat(krateo-sse-proxy): declare service.nodePort in values.schema.json - #34
Merged
Conversation
crdgen generates the KrateoSseProxy composition CRD from this chart's schema; it didn't declare service.nodePort, so the apiserver pruned spec.service.nodePort — breaking installer NodePort pinning for the events/notifications sse-proxy. Declare it (+ render it in the Service template). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LJsLqtryCgWwEt8FnPE1se
…rvice.nodePort schema release Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LJsLqtryCgWwEt8FnPE1se
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crdgen omitted service.nodePort from the KrateoSseProxy composition CRD (schema didn't declare it), so the apiserver pruned it — breaking installer NodePort pinning. Adds it to charts/krateo-sse-proxy schema (+ template if missing). 🤖 Generated with Claude Code