Use fmt.Stringer or encoding.TextMarshaler if possible#19
Open
otaku wants to merge 2 commits into
Open
Conversation
Collaborator
There was a problem hiding this comment.
Assign a value on line 172 and I will be typed in each case so this line would reduce to p.fmtString(v.String(), true) and the other case would be simplified similarly.
Author
|
One thing about this though is this will hide the actual fields, but generally it's helpful in cases such as time.Time. Would it be helpful to add prefix in for these cases? |
|
+1 or can it use GoStringer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An implementation for /issues/16 but also includes fmt.Stringer with priority given to Stringer before TextMarshaler.
I copied /pull/17 test implementation and added two other test cases.