fix(deps): update rust crate sqlx to 0.9#94
Open
renovate[bot] wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Deploying koyori with
|
| Latest commit: |
df8cb17
|
| Status: | ⚡️ Build in progress... |
renovate
Bot
force-pushed
the
renovate/sqlx-0.x
branch
23 times, most recently
from
208d63e to
e461b46
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Walkthroughバックエンドの ChangesSQLx 依存関係アップグレード
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/backend/Cargo.toml`:
- Line 56: The dependency line sqlx = { version = "0.9", features =
["runtime-tokio-rustls", "postgres", "time"] } requires MSRV 1.94.0, so add
rust-version = "1.94.0" to the same Cargo.toml containing that sqlx entry and
also pin the CI toolchain (create or update rust-toolchain.toml or set the
dtolnay/rust-toolchain action to channel 1.94.0) so CI uses Rust 1.94.0
consistently; ensure changes reference the existing sqlx declaration and the
rust-version key to make the MSRV explicit.
- Line 56: The public APIs in jobs (e.g., the connect/setup functions referenced
in apps/backend/src/jobs/mod.rs and apps/backend/src/jobs/github_webhook.rs)
expose Result<..., sqlx::Error>, which can clash because apalis-postgres pulls
sqlx 0.8 while the crate uses sqlx 0.9; change those function signatures to
return a non-sqlx public error type (for example anyhow::Error or Box<dyn
std::error::Error + Send + Sync>) or the apalis_postgres-specific error type,
and map/convert any internal sqlx errors to that chosen type before returning
(use .map_err(|e| e.into() / anyhow::Error::from(e)) in the connect/setup and
related functions so callers never see sqlx::Error across the crate boundary).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 3a24f089-ce72-475d-bfbd-d114de36b944
📒 Files selected for processing (1)
apps/backend/Cargo.toml
renovate
Bot
force-pushed
the
renovate/sqlx-0.x
branch
from
e461b46 to
1bb6dff
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
apps/backend/Cargo.toml (1)
56-56:⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift既存の主要な懸念事項が未解決のまま、SQLx 0.9 の破壊的変更による影響確認が必要です
過去のレビューで指摘された2つの重大な問題（MSRV 1.94.0 の未設定、
apalis-postgresとの sqlx バージョン競合）が未解決です。さらに、PR の説明に記載されている SQLx 0.9 の破壊的変更（query*()のSqlStr要件、Migrateトレイトの変更、型・ライフタイムパラメータの調整、Postgres 固有の動作変更）がコードベースに影響を与えないか確認が必要です。以下のスクリプトで、sqlx 0.9 へのアップグレード後もコンパイルとテストが通るか検証してください：
#!/bin/bash set -euo pipefail echo "== Cargo.toml の sqlx バージョン確認 ==" rg -n 'sqlx.*version' apps/backend/Cargo.toml echo echo "== cargo check でコンパイル確認 ==" cd apps/backend cargo check 2>&1 | head -100 echo echo "== 依存関係の競合確認（sqlx 0.8 と 0.9 の混在） ==" cargo tree -p sqlx 2>&1 | head -50🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/backend/Cargo.toml` at line 56, The Cargo.toml upgrade to sqlx = "0.9" may break build and conflicts with apalis-postgres and MSRV requirements; run the provided verification script in the repository root to (1) confirm the sqlx version entry in apps/backend/Cargo.toml, (2) run cargo check in apps/backend to surface compile errors caused by sqlx 0.9 breaking changes (e.g., query*() requiring SqlStr, Migrate trait signature changes, type/lifetime parameter adjustments, Postgres-specific behavior), and (3) inspect cargo tree -p sqlx to detect mixed 0.8/0.9 dependencies and apalis-postgres version mismatches; if issues appear, either pin sqlx back to a compatible 0.8 version or update dependent crates (including apalis-postgres) and adjust code paths that use query*(), Migrate implementations, and any Postgres-specific APIs to the sqlx 0.9 signatures, and ensure MSRV is set to >=1.94.0 in CI/toolchain configuration.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@apps/backend/Cargo.toml`:
- Line 56: The Cargo.toml upgrade to sqlx = "0.9" may break build and conflicts
with apalis-postgres and MSRV requirements; run the provided verification script
in the repository root to (1) confirm the sqlx version entry in
apps/backend/Cargo.toml, (2) run cargo check in apps/backend to surface compile
errors caused by sqlx 0.9 breaking changes (e.g., query*() requiring SqlStr,
Migrate trait signature changes, type/lifetime parameter adjustments,
Postgres-specific behavior), and (3) inspect cargo tree -p sqlx to detect mixed
0.8/0.9 dependencies and apalis-postgres version mismatches; if issues appear,
either pin sqlx back to a compatible 0.8 version or update dependent crates
(including apalis-postgres) and adjust code paths that use query*(), Migrate
implementations, and any Postgres-specific APIs to the sqlx 0.9 signatures, and
ensure MSRV is set to >=1.94.0 in CI/toolchain configuration.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e9ffbdff-e52a-40fb-b04b-4fe96b1d928c
📒 Files selected for processing (1)
apps/backend/Cargo.toml
renovate
Bot
force-pushed
the
renovate/sqlx-0.x
branch
2 times, most recently
from
d6f0ce1 to
1beedb7
Compare
Contributor
|
User renovate[bot] does not have write permissions |
renovate
Bot
force-pushed
the
renovate/sqlx-0.x
branch
5 times, most recently
from
ae4cc72 to
c5226e5
Compare
|
User renovate[bot] does not have write permissions |
renovate
Bot
force-pushed
the
renovate/sqlx-0.x
branch
from
c5226e5 to
45941d5
Compare
|
User renovate[bot] does not have write permissions |
renovate
Bot
force-pushed
the
renovate/sqlx-0.x
branch
from
45941d5 to
a9f17fc
Compare
|
User renovate[bot] does not have write permissions |
renovate
Bot
force-pushed
the
renovate/sqlx-0.x
branch
from
a9f17fc to
d55d995
Compare
|
User renovate[bot] does not have write permissions |
renovate
Bot
force-pushed
the
renovate/sqlx-0.x
branch
from
d55d995 to
629d030
Compare
|
User renovate[bot] does not have write permissions |
renovate
Bot
force-pushed
the
renovate/sqlx-0.x
branch
12 times, most recently
from
08ae086 to
7ad1a02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.8→0.9Release Notes
launchbadge/sqlx (sqlx)
v0.9.0Compare Source
Important Announcements
New Github Organization
Shortly after this release is published, the SQLx repository will be transferred to a new GitHub organization:
https://github.com/transact-rs/
This is because SQLx has not been owned or maintained by LaunchBadge, LLC. for a few years now, and has since been
informally transferred to the collective ownership of its principal authors. Moving the repository to a new
organization makes this change more clear, and also allows for potentially inviting outside collaborators.
Cargo.lockRemoved from TrackingThe
Cargo.lockhas been removed from tracking in Git. CI should now always test with the latest versions ofall dependencies by default, alongside our pass that checks with
cargo generate-lockfile -Z minimal-versions.This should eliminate the need for any PRs that update dependencies to also update
Cargo.lockorcontend with an endless stream of merge conflicts against it.
N.B.
cargo install --locked sqlx-cliwill no longer work. However,cargo install sqlx-clihas alwaysused the latest dependencies by default, ignoring the lockfile, so most users should not be affected. For users
requiring reproducible builds, consider maintaining your own lockfile instead; historically, we only ran
cargo updatesporadically, so relying on SQLx's lockfile offered few guarantees anyway.
See the manual page for
cargo installfor details.Breaking
As per our MSRV policy, the supported Rust version for this release cycle is
1.94.0.sqlx.tomlformat [[@abonander]]sqlx-clinow support per-crate configuration files (sqlx.toml)DATABASE_URLfor a crate (for multi-database workspaces)_sqlx_migrationstable (for multiple crates using the same database)sqlx-tomlto use.sqlx-clihas it enabled by default, butsqlxdoes not.so it's better to keep the default feature set as limited as possible.
This is something we learned the hard way.
sqlx::_configmodule in documentation.DATABASE_URLrenaming and global type overrides: [Link]_sqlx_migrationsrenaming and multiple schemas: [Link]chronowhentimeis enabled (e.g. when usingtower-sessions-sqlx-store): [Link]bigdecimalwhenrust_decimalis enabled is also shown, but problems withchrono/timeare more common.Migratetraitsqlx::migrate::resolve_blocking()is now#[doc(hidden)]and thus SemVer-exempt.tracinglogs from SQLx will need to update the spelling.PgAdvisoryLockGuard[[@bonsairobo]]Migrator::set_ignore_missingandset_lockingnow return&mut Selfinstead of&Selfwhich may break code in rare circumstances.
query!()macros for certain queries in Postgres.RawSqllifetime issues [[@abonander]]DBtype parameter to all methods ofRawSqlDecode,EncodeandTypeforBox,Arc,CowandRc[[@joeydewaal]]impl Decode for Cownow always decodesCow::Owned, lifetime is unlinkedquery*()functions now takeimpl SqlSafeStrwhich is only implemented for
&'static strandAssertSqlSafe.For all others, wrap in
AssertSqlSafe(<query>).Query<'static, DB>.SqlSafeStrtrait is deliberately similar tostd::panic::UnwindSafe,serving as a speedbump to warn users about naïvely building queries with
format!()while allowing a workaround for advanced usage that is easy to spot on code review.
PgConnectOptions::options()are now automatically escaped.Manual escaping of options is no longer necessary and may cause incorrect behavior.
runtime-tokio-native-tls)TransactionManagertrait insqlx.#[doc(hidden)],but it will break SeaORM if not proactively fixed.
str[[@abonander]]Vec<u8>will be inferred to beString(this should ultimately fix more code than it breaks).
SET NAMES utf8mb4 COLLATE utf8_general_ciis no longer sent by default; instead,SET NAMES utf8mb4is sent toallow the server to select the appropriate default collation (since this is version- and configuration-dependent).
MySqlConnectOptions::charset()and::collation()now imply::set_names(true)because they don't do anything otherwise.charsetdoesn't change what's sent in theProtocol::HandshakeResponse41packet as that normally onlymatters for error messages before
SET NAMESis sent.The default collation if
set_names = falseisutf8mb4_general_ci.RawSql::fetch_optional()now returnssqlx::Result<Option<DB::Row>>instead of
sqlx::Result<DB::Row>. Whoops.libsqlite3-sysversioning, feature flags, safety changes [[@abonander]]libsqlite3-sysversion is now specified using a range.The maximum of the range may now be increased in any backwards-compatible release.
The minimum of the range may only be increased in major releases.
If you have
libsqlite3-sysin your dependencies, Cargo should choose a compatible version automatically.If otherwise unconstrained, Cargo should choose the latest version supported.
sqlx-tomlfeature) is nowunsafe.sqlite-deserializeenablingSqliteConnection::serialize()andSqliteConnection::deserialize()sqlite-load-extensionenablingSqliteConnectOptions::extension()and::extension_with_entrypoint()sqlite-unlock-notifyenables internal use ofsqlite3_unlock_notify()SqliteValueandSqliteValueRefchanges:sqlite3_value*interface reserves the right to be stateful.Without protection, any call could theoretically invalidate values previously returned, leading to dangling pointers.
SqliteValueis now!SyncandSqliteValueRefis!Sendto prevent data races from concurrent accesses.SqliteValueinMutex, or convert theSqliteValueRefto an owned value.SqliteValueand any derivedSqliteValueRefs now internally track if that value has been used to decode aborrowed
&[u8]or&strand errors if it's used to decode any other type.per
SqliteValue/SqliteValueRef.SqliteValuefor details.PgLTree::fromtoFrom<Vec<PgLTreeLabel>>implementation [[@JerryQ17]]SqliteArguments[[@iamjpotts]].pgpassfile handling did not process backslash-escapes in the password part.Now it does, which may change what password is sent to the server.
#[derive(sqlx::Type)]automatically generateimpl PgHasArrayTypeby default for newtype structs [[@papaj-na-wrotkach]]Delete the manual impl or add
#[sqlx(no_pg_array)]where conflicts occur.offlineoptional to allow building withoutserde[[@CathalMullan]]mysql-rsafeatureor an error will be generated at runtime. RSA encryption is only used for plaintext (non-TLS) connections.
AnyTypeInfo[[@abonander]]Added
Arc<str>andArc<[u8]>(andRcequivalents) [[@joeydewaal]]runtime-smolandruntime-async-global-executorfeatures to replace usages of the deprecatedasync-stdcrate.no_txmigration support [[@AlexTMjugador]]Migrator::with_migrations()constructor [[@xb284524239]]sqlx.toml, update SQLite extension example [[@supleed2]]Json::into_inner()[[@chrxn1c]]SqlStr[[@joeydewaal]]PgNotificationstruct clone [[@michaelvanstraten]]Changed
OnceCell/Lazywith stdOnceLock/LazyLock[[@paolobarbolini]]Debugimplementations acrossPgRow,MySqlRowandSqliteRow[[@davidcornu]]QueryLoggerback [[@joeydewaal]].bind()inREADME.md[[@sobolevn]]randetceterato0.11.0libsqlite3-sysversion range to<0.38.0Fixed
futuresandfutures-util[[@paolobarbolini]]Pool.close: close all connections before returning [[@jpmelos]]ROLLBACKtransaction when dropped duringBEGIN. [[@kevincox]].envloading, caching, and invalidation [[@abonander]]which served as a useful comparison.
Command::cargo_bin()[[@abonander]]SASLprep[[@var4yn]]from_utf8_uncheckedwithfrom_utf8in SQLite column name handling [[@barry3406]]StdSocket::poll_ready()[[@abonander]]Configuration
📅 Schedule: (in timezone Asia/Tokyo)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit