feat: e2e foundation#111
Draft
sousuke0422 wants to merge 11 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
… tests - apps/e2e/ package with playwright.config.ts and signin smoke test - webServer boots backend (BACKEND_BIN) and frontend dev server - .github/workflows/e2e.yml: PG+Redis services, cargo build --release, chromium Assisted-by: multi-agent-shogun-aki-tweak
Assisted-by: multi-agent-shogun-aki-tweak
Assisted-by: multi-agent-shogun-aki-tweak
Assisted-by: multi-agent-shogun-aki-tweak
Upgrade the e2e foundation from a render-only smoke check into an actual login flow: - global-setup.ts: TEST_USER + seedUser() (register via API, mark email_verified directly in Postgres) + signIn() UI helper, exported as a shared module instead of a legacy globalSetup file. - tests/auth.setup.ts: setup project that performs the real sign-in (#email/#password -> サインイン -> assert redirect off /signin) and saves storageState for authenticated specs. - tests/home.authenticated.spec.ts: authenticated smoke reusing the saved session. - playwright.config.ts: 3 projects (setup / chromium / authenticated) with dependencies + storageState wiring. - package.json: type:module (import.meta under Playwright ESM) + pg/@types/pg. - pnpm-lock.yaml committed for reproducible CI installs. Rationale for setup-project over legacy globalSetup: webServer entries are guaranteed running before any project, so seeding and UI login always have the api/dev servers available — avoids globalSetup-vs-webServer ordering. Assisted-by: multi-agent-shogun-aki-tweak
sousuke0422
force-pushed
the
feat/e2e-foundation
branch
from
65d4d1b to
ffa224c
Compare
The backend cargo config (apps/backend/.cargo/config.toml) forces the mold linker via -fuse-ld=mold, but the e2e workflow built the backend without installing it, so cc failed with "cannot find ld". Add the same Install mold step that backend-test.yml/backend-build.yml already use. Assisted-by: multi-agent-shogun-aki-tweak
sousuke0422
force-pushed
the
feat/e2e-foundation
branch
3 times, most recently
from
c62f74e to
ccbdd06
Compare
|
Tip All tests passed and all changes approved!🟢 UI Tests: 20 tests unchanged |
Coverage Report for apps/frontend
File CoverageNo changed files found. |
Assisted-by: Codex
sousuke0422
force-pushed
the
feat/e2e-foundation
branch
7 times, most recently
from
f1196b4 to
0a1b453
Compare
sousuke0422
force-pushed
the
feat/e2e-foundation
branch
6 times, most recently
from
4680d7a to
5661943
Compare
sousuke0422
force-pushed
the
feat/e2e-foundation
branch
from
5661943 to
97c39a2
Compare
Assisted-by: multi-agent-shogun-aki-tweak
sousuke0422
force-pushed
the
feat/e2e-foundation
branch
from
2f346dd to
2ed1206
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wip