Skip to content

Add deprecation warning for default output-model-type #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koxudaxi merged 1 commit into from
Jan 3, 2026
Merged

Add deprecation warning for default output-model-type #2910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ skip = '.git,*.lock,tests,docs/cli-reference,CHANGELOG.md,docs/changelog.md'
filterwarnings = [
"error",
"ignore:^.*Pydantic v1 runtime support is deprecated.*:DeprecationWarning",
"ignore:^.*No --output-model-type specified.*:DeprecationWarning",
"ignore:^.*`--validation` option is deprecated.*",
"ignore:^.*--parent-scoped-naming is deprecated.*",
"ignore:^.*Field name `name` is duplicated on Pet.*",
Expand Down
16 changes: 16 additions & 0 deletions src/datamodel_code_generator/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,6 +1193,22 @@ def main(args: Sequence[str] | None = None) -> Exit: # noqa: PLR0911, PLR0912,
if config.disable_warnings:
warnings.simplefilter("ignore")

if (
namespace.output_model_type is None
and pyproject_config.get("output_model_type") is None
and config.output_model_type == DataModelType.PydanticBaseModel
):
warnings.warn(
"No --output-model-type specified. "
"The current default (pydantic.BaseModel, Pydantic v1) is deprecated "
"and will be removed in a future version. "
"Please explicitly specify --output-model-type. "
"Example: --output-model-type pydantic_v2.BaseModel. "
"See https://github.com/koxudaxi/datamodel-code-generator/issues/2466",
DeprecationWarning,
stacklevel=1,
)

if not is_pydantic_v2():
warnings.warn(
"Pydantic v1 runtime support is deprecated and will be removed in a future version. "
Expand Down
Loading