Refactor: Use model_validate/parse_obj for Parser config initialization by koxudaxi · Pull Request #2880 · koxudaxi/datamodel-code-generator

koxudaxi · 2025-12-31T03:19:59Z

Summary by CodeRabbit

Refactor
- Internal improvements to code structure and maintainability with no user-visible behavior changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…handling

coderabbitai · 2025-12-31T03:20:09Z

📝 Walkthrough

Walkthrough

The PR refactors the generate() function to extract parser configuration creation into a new internal helper _create_parser_config, which merges base GenerateConfig with parser-specific options while handling Pydantic v1/v2 compatibility. Parser instantiation is reorganized to use this centralized configuration builder across all input types.

Changes

Cohort / File(s)	Change Summary
Parser Configuration Refactoring `src/datamodel_code_generator/__init__.py`	Introduces new `_create_parser_config()` helper for building parser config with Pydantic v1/v2 compatibility (model_validate/model_copy vs. parse_obj); adds `_ConfigT` TypeVar and updates TYPE_CHECKING imports for parser config types (GraphQLParserConfigDict, OpenAPIParserConfigDict, ParserConfigDict); refactors `generate()` to use this helper for all parser types; reorganizes RAW_DATA_TYPES handling with explicit paths for CSV, YAML, JSON, Dict inputs; adds logic to compute default parser configuration fields (target_datetime_class, enum_field_as_literal, set_default_enum_member).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

PR #2874: Both PRs modify the generate() implementation to refactor parser configuration creation and instantiation, with one changing generate() signature to config-driven form.
PR #2878: Both PRs centralize parser configuration creation and pass configuration objects to parsers instead of multiple keyword arguments.

Poem

🐰 A parser's tale, now neatly told,
With configs merged, no more to fold,
From OpenAPI to GraphQL's call,
One helper function rules them all!
Compatibility secured, the path is clear,
Configuration generation draws near! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main refactoring change: replacing parser instantiation patterns with model_validate/parse_obj for configuration initialization, which is the primary objective of the pull request.

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-31T03:20:46Z

📚 Docs Preview: https://pr-2880.datamodel-code-generator.pages.dev

codspeed-hq · 2025-12-31T03:22:53Z

CodSpeed Performance Report

Merging #2880 will not alter performance

_{Comparing refactor/parser-config-model-validate (d760dfd) with main (efe8dfa)}

⚠️

Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 11 untouched
⏩ 98 skipped¹

98 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/datamodel_code_generator/__init__.py (1)
605-660: Consider removing unused noqa directives.

Static analysis indicates that several # noqa: PLC0415 directives in this block (lines 606, 614, 625, 641, 656) are unused because the PLC0415 rule is not enabled. If the rule is intentionally disabled project-wide, these directives can be safely removed to reduce noise.
🔎 Proposed cleanup
-        import json  # noqa: PLC0415
+        import json

             import csv  # noqa: PLC0415
-            import csv  # noqa: PLC0415
+            import csv

-                    import io  # noqa: PLC0415
+                    import io

-                import ast  # noqa: PLC0415
+                import ast

-        from genson import SchemaBuilder  # noqa: PLC0415
+        from genson import SchemaBuilder

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efe8dfa and d760dfd.

📒 Files selected for processing (1)

src/datamodel_code_generator/__init__.py

🧰 Additional context used

🧬 Code graph analysis (1)

src/datamodel_code_generator/__init__.py (9)

src/datamodel_code_generator/_types/graphql_parser_config_dict.py (1)

GraphQLParserConfigDict (33-146)

src/datamodel_code_generator/_types/openapi_parser_config_dict.py (1)

OpenAPIParserConfigDict (34-148)

src/datamodel_code_generator/_types/parser_config_dict.py (1)

ParserConfigDict (33-144)

src/datamodel_code_generator/_types/generate_config_dict.py (1)

GenerateConfigDict (39-160)

src/datamodel_code_generator/config.py (5)

GenerateConfig (65-198)

ParserConfig (201-324)

GraphQLParserConfig (327-331)

JSONSchemaParserConfig (334-335)

OpenAPIParserConfig (338-343)

src/datamodel_code_generator/util.py (2)

is_pydantic_v2 (52-57)

model_validate (261-265)

src/datamodel_code_generator/parser/jsonschema.py (2)

parse_obj (3450-3495)

JsonSchemaParser (526-3646)

src/datamodel_code_generator/parser/openapi.py (1)

OpenAPIParser (164-767)

src/datamodel_code_generator/parser/graphql.py (1)

GraphQLParser (62-508)

🪛 Ruff (0.14.10)

src/datamodel_code_generator/__init__.py

606-606: Unused noqa directive (non-enabled: PLC0415)