Skip to content

Fix _normalize_union_str to recursively normalize nested unions#2876

Merged
koxudaxi merged 1 commit intomainfrom
fix/normalize-union-str-recursive
Dec 30, 2025
Merged

Fix _normalize_union_str to recursively normalize nested unions#2876
koxudaxi merged 1 commit intomainfrom
fix/normalize-union-str-recursive

Conversation

@koxudaxi
Copy link
Copy Markdown
Owner

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 30, 2025

Warning

Rate limit exceeded

@koxudaxi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 5 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 2c7944d and 8aa1c04.

📒 Files selected for processing (1)
  • tests/main/test_public_api_signature_baseline.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 30, 2025

📚 Docs Preview: https://pr-2876.datamodel-code-generator.pages.dev

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.39%. Comparing base (2c7944d) to head (8aa1c04).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2876   +/-   ##
=======================================
  Coverage   99.38%   99.39%           
=======================================
  Files          91       91           
  Lines       15562    15576   +14     
  Branches     1828     1830    +2     
=======================================
+ Hits        15467    15481   +14     
  Misses         50       50           
  Partials       45       45           
Flag Coverage Δ
unittests 99.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@koxudaxi koxudaxi force-pushed the fix/normalize-union-str-recursive branch from 5809561 to 8aa1c04 Compare December 30, 2025 17:56
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 30, 2025

CodSpeed Performance Report

Merging #2876 will not alter performance

Comparing fix/normalize-union-str-recursive (8aa1c04) with main (2c7944d)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 11 untouched
⏩ 98 skipped1

Footnotes

  1. 98 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@koxudaxi koxudaxi enabled auto-merge (squash) December 30, 2025 17:58
@koxudaxi koxudaxi merged commit 592723c into main Dec 30, 2025
33 checks passed
@koxudaxi koxudaxi deleted the fix/normalize-union-str-recursive branch December 30, 2025 17:59
@github-actions
Copy link
Copy Markdown
Contributor

Breaking Change Analysis

Result: No breaking changes detected

Reasoning: This PR only modifies a test file (tests/main/test_public_api_signature_baseline.py). The _normalize_union_str function is a test helper used internally for comparing type signatures in tests - it's not part of the public API, CLI, code generation output, or any user-facing functionality. The change improves the test helper to recursively normalize nested union types, which makes the test assertions more robust. No breaking changes for users.


This analysis was performed by Claude Code Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 1, 2026

🎉 Released in 0.51.0

This PR is now available in the latest release. See the release notes for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant