Skip to content

Fix pre-commit hooks and pytest for Windows environments#2871

Merged
koxudaxi merged 1 commit intomainfrom
fix/windows-support
Dec 30, 2025
Merged

Fix pre-commit hooks and pytest for Windows environments#2871
koxudaxi merged 1 commit intomainfrom
fix/windows-support

Conversation

@koxudaxi
Copy link
Copy Markdown
Owner

Related PRs: #2869

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 30, 2025

Warning

Rate limit exceeded

@koxudaxi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 29 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 8f18513 and 252a3bb.

📒 Files selected for processing (2)
  • .pre-commit-config.yaml
  • tests/conftest.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

📚 Docs Preview: https://pr-2871.datamodel-code-generator.pages.dev

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 30, 2025

CodSpeed Performance Report

Merging #2871 will not alter performance

Comparing fix/windows-support (252a3bb) with main (8f18513)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 11 untouched
⏩ 98 skipped1

Footnotes

  1. 98 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.38%. Comparing base (6dd1dbe) to head (252a3bb).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2871   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files          91       91           
  Lines       15555    15555           
  Branches     1827     1827           
=======================================
  Hits        15460    15460           
  Misses         50       50           
  Partials       45       45           
Flag Coverage Δ
unittests 99.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@koxudaxi koxudaxi merged commit c3e159c into main Dec 30, 2025
36 checks passed
@koxudaxi koxudaxi deleted the fix/windows-support branch December 30, 2025 13:27
@github-actions
Copy link
Copy Markdown
Contributor

Breaking Change Analysis

Result: No breaking changes detected

Reasoning: PR #2871 contains only internal changes for Windows compatibility: (1) Pre-commit hook modifications to support both Unix and Windows tox paths (.tox//bin vs .tox//Scripts), and (2) A test fixture fix to normalize line endings when comparing external file content. These changes affect only development tooling and test infrastructure, not the library's generated code output, templates, CLI, Python API, default behavior, or error handling. End users will not experience any changes in behavior.


This analysis was performed by Claude Code Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 1, 2026

🎉 Released in 0.51.0

This PR is now available in the latest release. See the release notes for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant