Skip to content

Support 'timestamp with time zone' format#2762

Merged
koxudaxi merged 1 commit intomainfrom
feature/support-timestamp-with-time-zone-format
Dec 23, 2025
Merged

Support 'timestamp with time zone' format#2762
koxudaxi merged 1 commit intomainfrom
feature/support-timestamp-with-time-zone-format

Conversation

@koxudaxi
Copy link
Copy Markdown
Owner

Fixes: #642

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 23, 2025

Warning

Rate limit exceeded

@koxudaxi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 7b5f08f and a3d9ab7.

📒 Files selected for processing (2)
  • src/datamodel_code_generator/parser/jsonschema.py
  • tests/parser/test_jsonschema.py
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/support-timestamp-with-time-zone-format

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 23, 2025

CodSpeed Performance Report

Merging #2762 will not alter performance

Comparing feature/support-timestamp-with-time-zone-format (a3d9ab7) with main (7b5f08f)

Summary

✅ 73 untouched
⏩ 10 skipped1

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.47%. Comparing base (7b5f08f) to head (a3d9ab7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2762   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          83       83           
  Lines       12481    12484    +3     
  Branches     1490     1490           
=======================================
+ Hits        12415    12418    +3     
  Misses         35       35           
  Partials       31       31           
Flag Coverage Δ
unittests 99.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@koxudaxi koxudaxi merged commit 525166f into main Dec 23, 2025
37 checks passed
@koxudaxi koxudaxi deleted the feature/support-timestamp-with-time-zone-format branch December 23, 2025 14:15
@github-actions
Copy link
Copy Markdown
Contributor

Breaking Change Analysis

Result: No breaking changes detected

Reasoning: This PR is purely additive - it adds support for the PostgreSQL "timestamp with time zone" format string by mapping it to Types.date_time. No existing behavior is modified. Previously unrecognized format strings would fall back to a default type; now this specific format is recognized and correctly typed. This is a feature enhancement that improves code generation for users with PostgreSQL-style schemas, without affecting any existing users or requiring any changes to their workflows.


This analysis was performed by Claude Code Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timestamp with timezone format string type is generated as a string property of the pydantic model

1 participant