Add Python 3.13 deprecation warning documentation#2743
Conversation
|
Warning Rate limit exceeded@koxudaxi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 57 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughDocumentation and test docstring updates add guidance for Python 3.13 deprecation warnings when using Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
docs/cli-reference/typing-customization.md (1)
667-673: Good clarification of the Python 3.13/Pydantic v1 warning, but adjust strong-style for markdownlint.The new deprecation note is accurate and ties
--disable-future-importsto a concrete Python 3.13 + Pydantic v1<1.10.18 warning scenario. However, markdownlint (MD050) is flagging the bold text at line 667; if you want to satisfy that rule, consider switching to underscore style (e.g.__Python 3.13+ Deprecation Warning:__) or relaxing the rule in your config.docs/python-version-compatibility.md (1)
334-341: Clarify pytest filterwarnings path for Pydantic v2 users.The pytest configuration (line 339) specifies the module path
pydantic.v1.typing, which is specific to Pydantic v1. Since the troubleshooting section advises upgrading to Pydantic v2 as the primary solution, consider clarifying whether v2 users experience the same warning or noting that this suppress configuration is for v1 only.You may want to verify whether Pydantic v2 users encounter the same
typing._eval_typedeprecation warning or if the warning path differs.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
docs/cli-reference/typing-customization.mddocs/python-version-compatibility.mdtests/main/jsonschema/test_main_jsonschema.py
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
docs/python-version-compatibility.md
316-316: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
docs/cli-reference/typing-customization.md
667-667: Strong style
Expected: underscore; Actual: asterisk
(MD050, strong-style)
667-667: Strong style
Expected: underscore; Actual: asterisk
(MD050, strong-style)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: 3.10 on Ubuntu
- GitHub Check: 3.13 on Windows
- GitHub Check: 3.10 on Windows
- GitHub Check: py312-isort5 on Ubuntu
- GitHub Check: 3.14 on Windows
- GitHub Check: 3.11 on Windows
- GitHub Check: 3.12 on Windows
- GitHub Check: Analyze (python)
- GitHub Check: benchmarks
🔇 Additional comments (2)
tests/main/jsonschema/test_main_jsonschema.py (1)
141-146: Docstring note is clear and consistent with the PR objective.The Python 3.13/Pydantic v1 deprecation warning explanation and suggested mitigations are accurate and helpful in this test’s docstring context.
docs/python-version-compatibility.md (1)
312-346: Well-structured troubleshooting guidance addressing the PR objectives.The new troubleshooting section appropriately documents the Python 3.13 deprecation warning, clearly explains the cause, and provides three practical solutions ordered from best-practice (upgrade) to temporary workarounds. The note about Python 3.14+ native deferred annotations provides helpful context for future compatibility.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2743 +/- ##
=======================================
Coverage 99.37% 99.37%
=======================================
Files 83 83
Lines 12233 12233
Branches 1467 1467
=======================================
Hits 12156 12156
Misses 45 45
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #2743 will not alter performanceComparing Summary
Footnotes
|
Fixes: #2287
Summary by CodeRabbit
--disable-future-importsflag.✏️ Tip: You can customize this high-level summary in your review settings.