Skip to content

Fix nullable field access in custom templates with strict_nullable#2715

Merged
koxudaxi merged 1 commit intomainfrom
fix-issue-1907-nullable-in-custom-template
Dec 20, 2025
Merged

Fix nullable field access in custom templates with strict_nullable#2715
koxudaxi merged 1 commit intomainfrom
fix-issue-1907-nullable-in-custom-template

Conversation

@koxudaxi
Copy link
Copy Markdown
Owner

Fixes: #1907

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 20, 2025

Warning

Rate limit exceeded

@koxudaxi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 39 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e3a2cf5 and 4ff8c57.

📒 Files selected for processing (3)
  • src/datamodel_code_generator/parser/jsonschema.py (4 hunks)
  • src/datamodel_code_generator/parser/openapi.py (1 hunks)
  • tests/parser/test_openapi.py (1 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-issue-1907-nullable-in-custom-template

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.34%. Comparing base (e3a2cf5) to head (4ff8c57).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2715   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files          81       81           
  Lines       11534    11543    +9     
  Branches     1387     1387           
=======================================
+ Hits        11458    11467    +9     
  Misses         45       45           
  Partials       31       31           
Flag Coverage Δ
unittests 99.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 20, 2025

CodSpeed Performance Report

Merging #2715 will not alter performance

Comparing fix-issue-1907-nullable-in-custom-template (4ff8c57) with main (e3a2cf5)

Summary

✅ 52 untouched
⏩ 10 skipped1

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@koxudaxi
Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 20, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@koxudaxi koxudaxi merged commit 3e7b16b into main Dec 20, 2025
37 checks passed
@koxudaxi koxudaxi deleted the fix-issue-1907-nullable-in-custom-template branch December 20, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nullability info excluded from templates for optional, no-default OpenAPI fields

1 participant