Skip to content

Fix msgspec tag_field conflict with discriminator field definition#2663

Merged
koxudaxi merged 1 commit intomainfrom
fix/msgspec-discriminator-tag-field-conflict
Dec 14, 2025
Merged

Fix msgspec tag_field conflict with discriminator field definition#2663
koxudaxi merged 1 commit intomainfrom
fix/msgspec-discriminator-tag-field-conflict

Conversation

@koxudaxi
Copy link
Copy Markdown
Owner

Summary

  • Fix msgspec discriminator fields conflicting with tag_field parameter
  • Skip rendering is_classvar fields in msgspec template (msgspec manages them via tag_field)
  • Fix unused import removal to properly handle reference-counted imports

@koxudaxi koxudaxi force-pushed the fix/msgspec-discriminator-tag-field-conflict branch from 6ba4420 to 7e5fa7f Compare December 14, 2025 17:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.60%. Comparing base (747fed5) to head (7e5fa7f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2663      +/-   ##
==========================================
- Coverage   99.66%   99.60%   -0.06%     
==========================================
  Files          76       76              
  Lines       10481    10485       +4     
  Branches     1261     1263       +2     
==========================================
- Hits        10446    10444       -2     
- Misses         16       21       +5     
- Partials       19       20       +1     
Flag Coverage Δ
unittests 99.60% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 14, 2025

CodSpeed Performance Report

Merging #2663 will not alter performance

Comparing fix/msgspec-discriminator-tag-field-conflict (7e5fa7f) with main (747fed5)

Summary

✅ 50 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@koxudaxi koxudaxi marked this pull request as ready for review December 14, 2025 18:05
@koxudaxi koxudaxi merged commit f7ffbd0 into main Dec 14, 2025
38 of 39 checks passed
@koxudaxi koxudaxi deleted the fix/msgspec-discriminator-tag-field-conflict branch December 14, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant