chore(bip0039): update phf deps#150
Conversation
dosubot
Bot
added
size:XS
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3b7f521e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| hmac = { version = "0.13", default-features = false } | ||
| pbkdf2 = { version = "0.13", default-features = false } | ||
| phf = { version = "0.13", default-features = false } | ||
| phf = { version = "0.14", default-features = false } |
There was a problem hiding this comment.
With phf 0.14, a downstream crate can enable phf/ptrhash on the shared runtime dependency through Cargo feature unification, but this crate's build script always runs phf_codegen without its matching ptrhash feature. In that consumer configuration the generated wordlist maps still emit the default CHD fields like disps, while phf::Map expects the ptrhash fields pilots/remap, so bip0039 fails to compile even though its own features did not change; either keep the 0.13 layout or force/propagate the same layout feature for both runtime and codegen.
Useful? React with 👍 / 👎.
1 participant
Which issue does this PR close?
Closes #148
Closes #149
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
AI usage statement