Skip to content

fix(Tooltip): default arrowBoundaryOffset to 16 (DS-5145) #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KamilEmeleev merged 1 commit into from
May 29, 2026
Merged

fix(Tooltip): default arrowBoundaryOffset to 16 (DS-5145) #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
181 changes: 36 additions & 145 deletions packages/components/src/components/Tooltip/Tooltip.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useBoolean } from '@koobiq/react-core';
import { IconCircleQuestion24 } from '@koobiq/react-icons';
import type { Meta, StoryObj } from '@storybook/react';

import { Button, type ButtonProps } from '../Button';
import { Button } from '../Button';
import { FlexBox } from '../FlexBox';
import { Grid, GridItem } from '../Grid';
import { IconButton } from '../IconButton';
Expand Down Expand Up @@ -207,154 +207,45 @@ export const ControlledOpen: Story = {
};

export const Placement: Story = {
render: function Render(args) {
const [isOpen, { on, off, set }] = useBoolean();
const [placement, setPlacement] = useState<TooltipPropPlacement>();
const anchorRef = useRef<HTMLElement | null>(null);

const onHoverStart = (placement: TooltipPropPlacement) => {
const fn: ButtonProps['onHoverStart'] = (e) => {
on();
setPlacement(placement);
anchorRef.current = e.target as HTMLElement;
};

return fn;
};
render: (args) => {
const placements: TooltipPropPlacement[] = [
'top start',
'top',
'top end',
'start top',
'start',
'start bottom',
'end top',
'end',
'end bottom',
'bottom start',
'bottom',
'bottom end',
];

return (
<Grid cols={{ xs: 3, m: 5 }} gap="l">
<GridItem colStart={{ xs: 1, m: 2 }}>
<Button
variant="fade-contrast-filled"
onHoverStart={onHoverStart('top start')}
onHoverEnd={off}
fullWidth
>
top start
</Button>
</GridItem>
<GridItem>
<Button
variant="fade-contrast-filled"
onHoverStart={onHoverStart('top')}
onHoverEnd={off}
fullWidth
{placements.map((placement, index) => (
<GridItem
key={placement}
colStart={index % 3 === 0 ? { xs: 1, m: 2 } : undefined}
>
top
</Button>
</GridItem>
<GridItem>
<Button
variant="fade-contrast-filled"
onHoverStart={onHoverStart('top end')}
onHoverEnd={off}
fullWidth
>
top end
</Button>
</GridItem>
<GridItem colStart={{ xs: 1, m: 2 }}>
<Button
variant="fade-contrast-filled"
onHoverStart={onHoverStart('start top')}
onHoverEnd={off}
fullWidth
>
start top
</Button>
</GridItem>
<GridItem>
<Button
variant="fade-contrast-filled"
onHoverStart={onHoverStart('start')}
onHoverEnd={off}
fullWidth
>
start
</Button>
</GridItem>
<GridItem>
<Button
variant="fade-contrast-filled"
onHoverStart={onHoverStart('start bottom')}
onHoverEnd={off}
fullWidth
>
start bottom
</Button>
</GridItem>
<GridItem colStart={{ xs: 1, m: 2 }}>
<Button
variant="fade-contrast-filled"
onHoverStart={onHoverStart('end top')}
onHoverEnd={off}
fullWidth
>
end top
</Button>
</GridItem>
<GridItem>
<Button
variant="fade-contrast-filled"
onHoverStart={onHoverStart('end')}
onHoverEnd={off}
fullWidth
>
end
</Button>
</GridItem>
<GridItem>
<Button
variant="fade-contrast-filled"
onHoverStart={onHoverStart('end bottom')}
onHoverEnd={off}
fullWidth
>
end bottom
</Button>
</GridItem>
<GridItem colStart={{ xs: 1, m: 2 }}>
<Button
variant="fade-contrast-filled"
onHoverStart={onHoverStart('bottom start')}
onHoverEnd={off}
fullWidth
>
bottom start
</Button>
</GridItem>
<GridItem>
<Button
variant="fade-contrast-filled"
onHoverStart={onHoverStart('bottom')}
onHoverEnd={off}
fullWidth
>
bottom
</Button>
</GridItem>
<GridItem>
<Button
variant="fade-contrast-filled"
onHoverStart={onHoverStart('bottom end')}
onHoverEnd={off}
fullWidth
>
bottom end
</Button>
</GridItem>
<Tooltip
delay={0}
closeDelay={0}
isOpen={isOpen}
onOpenChange={(open) => set(open)}
placement={placement}
anchorRef={anchorRef}
{...args}
>
Check out my placement
</Tooltip>
<Tooltip
delay={0}
closeDelay={0}
hideArrow={false}
placement={placement}
control={(props) => (
<Button variant="fade-contrast-filled" fullWidth {...props}>
{placement}
</Button>
)}
{...args}
>
Check out my placement
</Tooltip>
</GridItem>
))}
</Grid>
);
},
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/Tooltip/Tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export const Tooltip = forwardRef<TooltipRef, TooltipProps>((props, ref) => {
// Boolean props should default to `false`. This default is kept for compatibility.
hideArrow = true,
placement: placementProp = 'top',
arrowBoundaryOffset = 16,
closeDelay = 120,
delay = 120,
isDisabled: isDisabledProp,
Expand All @@ -47,7 +48,6 @@ export const Tooltip = forwardRef<TooltipRef, TooltipProps>((props, ref) => {
onOpenChange,
portalContainer,
offset: offsetProp,
arrowBoundaryOffset,
...other
} = props;

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/Tooltip/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export type TooltipProps = ExtendableProps<
anchorRef?: RefObject<HTMLElement | null>;
/**
* The minimum distance the arrow's edge should be from the edge of the overlay element.
* @default 0
* @default 16
*/
arrowBoundaryOffset?: number;
/**
Expand Down
Loading