feat(ag-grid-angular-theme): added KbqAgGridLoadingOverlay, KbqAgGridSkeletonCellRenderer directives (#DS-4937)#174
feat(ag-grid-angular-theme): added KbqAgGridLoadingOverlay, KbqAgGridSkeletonCellRenderer directives (#DS-4937)#174artembelik wants to merge 5 commits into
KbqAgGridLoadingOverlay, KbqAgGridSkeletonCellRenderer directives (#DS-4937)#174Conversation
|
Visit the preview URL for this PR (updated for commit 4c43df6): https://data-grid-next--data-grid-pr-174-o77fabf5.web.app (expires Tue, 09 Jun 2026 14:30:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b9d49913f5b5988e9af8690a8b37f16143707448 |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
KbqAgGridLoadingOverlay, KbqAgGridSkeletonCellRenderer directives (#DS-4937)
There was a problem hiding this comment.
Pull request overview
Adds a skeleton-based loading experience for ag-grid-angular within the @koobiq/ag-grid-angular-theme package, including a reusable loading overlay directive/component pair, a skeleton cell renderer for Infinite Row Model, theme styles, and dev + test coverage to validate visuals and behavior.
Changes:
- Introduced
KbqAgGridLoadingOverlaydirective +KbqAgGridLoadingOverlayComponentwith optional DI-based configuration (rows/cols). - Added
KbqAgGridSkeletonCellRendererfor Infinite Row Model placeholders and corresponding theme SCSS for skeleton visuals. - Added unit tests and Playwright e2e/screenshot tests, plus dev routes/pages demonstrating overlay and lazy-loading skeletons.
Reviewed changes
Copilot reviewed 13 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ag-grid-angular-theme/tests/loading-overlay.ng.spec.ts | Unit tests for directive behavior and overlay component rendering/config. |
| packages/ag-grid-angular-theme/src/theme.scss | Adds skeleton renderer + loading overlay styling and disables row interaction during skeleton rendering. |
| packages/ag-grid-angular-theme/src/skeleton-cell-renderer.ng.ts | Adds Angular loading cell renderer component for infinite row model skeletons. |
| packages/ag-grid-angular-theme/src/module.ng.ts | Exposes the new loading overlay directive via the theme module exports. |
| packages/ag-grid-angular-theme/src/loading-overlay.ng.ts | Implements the loading overlay directive, component, and configuration provider/token. |
| packages/ag-grid-angular-theme/index.ts | Exports the new overlay and skeleton renderer APIs from the package entrypoint. |
| dev/ag-grid-angular/src/tests/loading-overlay.playwright-spec.ts | Playwright coverage for overlay visibility/toggling + screenshot assertions. |
| dev/ag-grid-angular/src/tests/loading-overlay.ng.ts | Dev demo component for the loading overlay feature (with config provider). |
| dev/ag-grid-angular/src/tests/lazy-loading.playwright-spec.ts | Playwright coverage for skeleton cells appearing/disappearing during infinite scrolling. |
| dev/ag-grid-angular/src/tests/lazy-loading.ng.ts | Dev demo component for infinite model skeleton cell renderer usage. |
| dev/ag-grid-angular/src/row-data.ts | Adds a signal-based IDatasource factory used by the lazy-loading dev demo. |
| dev/ag-grid-angular/src/overview.ng.ts | Adds overview toggle + wiring to demonstrate the loading overlay in the main dev overview. |
| dev/ag-grid-angular/src/main.ts | Adds dev routes for the new loading-overlay and lazy-loading demo pages. |
|
@rmnturov посмори пожалуйста lazy loading + skeleton: loading overlay + skeleton: |
|
No description provided.