chore(ag-grid-angular-theme): deprecate KbqAgGridShortcuts#165
Merged
Conversation
KbqAgGridShortcuts
|
Visit the preview URL for this PR (updated for commit e4ed886): https://data-grid-next--data-grid-pr-165-eob278qa.web.app (expires Wed, 20 May 2026 09:45:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b9d49913f5b5988e9af8690a8b37f16143707448 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR deprecates KbqAgGridShortcuts and shifts shortcut behavior into dedicated ag-grid Angular directives, while adding unit coverage for those directive entry points.
Changes:
- Marks
KbqAgGridShortcutsand its methods as deprecated with migration guidance. - Moves shortcut logic directly into the dedicated directives and relocates copy formatter exports.
- Adds tests for Tab navigation, Shift+Arrow row selection, Ctrl/Cmd shortcuts, and copy behavior.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
packages/ag-grid-angular-theme/src/shortcuts.ng.ts |
Deprecates the shortcut service and imports copy formatter APIs from the copy directive file. |
packages/ag-grid-angular-theme/src/copy-by-ctrl-c.ng.ts |
Owns copy shortcut logic and exports copy formatter types/helpers. |
packages/ag-grid-angular-theme/src/select-rows-by-shift-arrow.ng.ts |
Implements Shift+Arrow range selection directly in the directive. |
packages/ag-grid-angular-theme/src/select-rows-by-ctrl-click.ng.ts |
Implements Ctrl/Cmd+Click row toggling directly in the directive. |
packages/ag-grid-angular-theme/src/select-all-rows-by-ctrl-a.ng.ts |
Implements Ctrl/Cmd+A selection directly in the directive. |
packages/ag-grid-angular-theme/src/to-next-row-by-tab.ng.ts |
Implements Tab-to-next-row navigation directly in the directive. |
packages/ag-grid-angular-theme/src/module.ng.ts |
Suppresses deprecation linting for the still-provided shortcut service. |
packages/ag-grid-angular-theme/tests/copy-by-ctrl-c.ng.spec.ts |
Adds tests for copy shortcut behavior. |
packages/ag-grid-angular-theme/tests/select-all-rows-by-ctrl-a.ng.spec.ts |
Adds tests for Ctrl/Cmd+A row selection. |
packages/ag-grid-angular-theme/tests/select-rows-by-ctrl-click.ng.spec.ts |
Adds tests for Ctrl+Click row selection toggling. |
packages/ag-grid-angular-theme/tests/select-rows-by-shift-arrow.ng.spec.ts |
Adds tests for Shift+Arrow row selection. |
packages/ag-grid-angular-theme/tests/to-next-row-by-tab.ng.spec.ts |
Adds tests for Tab row navigation behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.