Skip to content

chore(ag-grid-angular-theme): deprecate KbqAgGridShortcuts#165

Merged
artembelik merged 1 commit into
mainfrom
chore/clipboard-deprecation
May 15, 2026
Merged

chore(ag-grid-angular-theme): deprecate KbqAgGridShortcuts#165
artembelik merged 1 commit into
mainfrom
chore/clipboard-deprecation

Conversation

@artembelik
Copy link
Copy Markdown
Contributor

No description provided.

@artembelik artembelik self-assigned this May 15, 2026
Copilot AI review requested due to automatic review settings May 15, 2026 09:43
@artembelik artembelik changed the title chore(ag-grid-angular-theme): deprecate KbqAgGridShortcuts chore(ag-grid-angular-theme): deprecate KbqAgGridShortcuts May 15, 2026
@github-actions
Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit e4ed886):

https://data-grid-next--data-grid-pr-165-eob278qa.web.app

(expires Wed, 20 May 2026 09:45:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b9d49913f5b5988e9af8690a8b37f16143707448

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR deprecates KbqAgGridShortcuts and shifts shortcut behavior into dedicated ag-grid Angular directives, while adding unit coverage for those directive entry points.

Changes:

  • Marks KbqAgGridShortcuts and its methods as deprecated with migration guidance.
  • Moves shortcut logic directly into the dedicated directives and relocates copy formatter exports.
  • Adds tests for Tab navigation, Shift+Arrow row selection, Ctrl/Cmd shortcuts, and copy behavior.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
packages/ag-grid-angular-theme/src/shortcuts.ng.ts Deprecates the shortcut service and imports copy formatter APIs from the copy directive file.
packages/ag-grid-angular-theme/src/copy-by-ctrl-c.ng.ts Owns copy shortcut logic and exports copy formatter types/helpers.
packages/ag-grid-angular-theme/src/select-rows-by-shift-arrow.ng.ts Implements Shift+Arrow range selection directly in the directive.
packages/ag-grid-angular-theme/src/select-rows-by-ctrl-click.ng.ts Implements Ctrl/Cmd+Click row toggling directly in the directive.
packages/ag-grid-angular-theme/src/select-all-rows-by-ctrl-a.ng.ts Implements Ctrl/Cmd+A selection directly in the directive.
packages/ag-grid-angular-theme/src/to-next-row-by-tab.ng.ts Implements Tab-to-next-row navigation directly in the directive.
packages/ag-grid-angular-theme/src/module.ng.ts Suppresses deprecation linting for the still-provided shortcut service.
packages/ag-grid-angular-theme/tests/copy-by-ctrl-c.ng.spec.ts Adds tests for copy shortcut behavior.
packages/ag-grid-angular-theme/tests/select-all-rows-by-ctrl-a.ng.spec.ts Adds tests for Ctrl/Cmd+A row selection.
packages/ag-grid-angular-theme/tests/select-rows-by-ctrl-click.ng.spec.ts Adds tests for Ctrl+Click row selection toggling.
packages/ag-grid-angular-theme/tests/select-rows-by-shift-arrow.ng.spec.ts Adds tests for Shift+Arrow row selection.
packages/ag-grid-angular-theme/tests/to-next-row-by-tab.ng.spec.ts Adds tests for Tab row navigation behavior.

Comment thread packages/ag-grid-angular-theme/src/to-next-row-by-tab.ng.ts
Comment thread packages/ag-grid-angular-theme/tests/to-next-row-by-tab.ng.spec.ts
Comment thread packages/ag-grid-angular-theme/src/copy-by-ctrl-c.ng.ts
Comment thread packages/ag-grid-angular-theme/src/shortcuts.ng.ts
Comment thread packages/ag-grid-angular-theme/src/copy-by-ctrl-c.ng.ts
Comment thread packages/ag-grid-angular-theme/src/select-rows-by-shift-arrow.ng.ts
Comment thread packages/ag-grid-angular-theme/src/copy-by-ctrl-c.ng.ts
Comment thread packages/ag-grid-angular-theme/src/copy-by-ctrl-c.ng.ts
Comment thread packages/ag-grid-angular-theme/src/select-rows-by-shift-arrow.ng.ts
Comment thread packages/ag-grid-angular-theme/src/copy-by-ctrl-c.ng.ts
@artembelik artembelik merged commit c33a6da into main May 15, 2026
9 checks passed
@artembelik artembelik deleted the chore/clipboard-deprecation branch May 15, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants