Skip to content

chore(ag-grid-angular-theme): deprecate disableCellFocusStyles in favor of kbqAgGridThemeDisableCellFocusStyles#164

Merged
artembelik merged 1 commit into
mainfrom
chore/input-name
May 15, 2026
Merged

chore(ag-grid-angular-theme): deprecate disableCellFocusStyles in favor of kbqAgGridThemeDisableCellFocusStyles#164
artembelik merged 1 commit into
mainfrom
chore/input-name

Conversation

@artembelik
Copy link
Copy Markdown
Contributor

@artembelik artembelik self-assigned this May 15, 2026
Copilot AI review requested due to automatic review settings May 15, 2026 08:14
@artembelik artembelik changed the title chore(ag-grid-angular-theme): deprecate disableCellFocusStyles in favor of kbqAgGridThemeDisableCellFocusStyles chore(ag-grid-angular-theme): deprecate disableCellFocusStyles in favor of kbqAgGridThemeDisableCellFocusStyles May 15, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Deprecates the disableCellFocusStyles input on KbqAgGridTheme in favor of a new aliased input kbqAgGridThemeDisableCellFocusStyles, to follow the prefixed naming convention used by other inputs on this directive.

Changes:

  • Adds a new _disableCellFocusStyles input aliased as kbqAgGridThemeDisableCellFocusStyles, and OR's it with the existing deprecated input in the host class binding.
  • Marks the original disableCellFocusStyles input as @deprecated.
  • Updates dev and test usages to the new input name.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/ag-grid-angular-theme/src/theme.ng.ts Adds new aliased input and deprecates the old one; updates host binding to consider both.
packages/ag-grid-angular-theme/tests/theme.ng.spec.ts Updates test template to use the new input alias.
dev/ag-grid-angular/src/tests/theme.ng.ts Updates e2e demo template to use the new input alias.
dev/ag-grid-angular/src/overview.ng.ts Updates overview demo binding to use the new input alias.

@github-actions
Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 188c810):

https://data-grid-next--data-grid-pr-164-69x490rv.web.app

(expires Wed, 20 May 2026 08:17:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b9d49913f5b5988e9af8690a8b37f16143707448

@artembelik artembelik merged commit cf024b9 into main May 15, 2026
9 checks passed
@artembelik artembelik deleted the chore/input-name branch May 15, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants