fix(ag-grid-angular-theme): dropdown background (#DS-5077)#163
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 8d769d9): https://data-grid-next--data-grid-pr-163-a6bk9osj.web.app (expires Tue, 19 May 2026 13:56:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b9d49913f5b5988e9af8690a8b37f16143707448 |
🚨 E2E tests failedReview the report for details. 💡 Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Koobiq AG Grid Angular theme to ensure dropdowns/popups (notably filter UI) render with the correct “card” background, and adds/updates visual coverage to prevent regressions.
Changes:
- Scoped popup/select-list backgrounds by overriding
--ag-background-colorfor.ag-popupand.ag-select-list. - Set
--ag-menu-background-colorat the theme root to align AG Grid menu surfaces with Koobiq “card” background. - Added a Playwright screenshot test case covering the filter popup in both light and dark themes (and disabled cell focus styles in the theme e2e component for consistent visuals).
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ag-grid-angular-theme/src/theme.scss | Updates theme CSS variables/mixins to apply card background to popups/menus and select lists. |
| dev/ag-grid-angular/src/tests/theme.playwright-spec.ts | Adds screenshot coverage for the opened filter popup in light/dark. |
| dev/ag-grid-angular/src/tests/theme.ng.ts | Enables disableCellFocusStyles for the theme e2e grid instance (stabilizes visual state). |
Contributor
Author
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.