fix: after update (#DS-5079)#1622
Conversation
|
Visit the preview URL for this PR (updated for commit fcddba1): https://koobiq-next--prs-1622-815op42q.web.app (expires Tue, 09 Jun 2026 18:46:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
lskramarov
force-pushed
the
fix/after-update
branch
from
b2a980d to
e8802e3
Compare
🚨 E2E tests failedReview the report for details. 💡 Comment |
There was a problem hiding this comment.
Pull request overview
This PR hardens KbqSelect’s “hidden selected items” calculation logic to avoid runtime errors when expected trigger DOM elements aren’t present yet (regression observed after a framework update), and adds a unit test to prevent the crash from returning.
Changes:
- Add null-guards in
calculateHiddenItemswhen.kbq-select__match-hidden-text/.kbq-select__match-listaren’t available yet. - Make
getTotalVisibleItems()tolerate a missing.kbq-select__match-hidden-textelement before callingRenderer2.setStyle. - Add a regression unit test ensuring
calculateHiddenItems()doesn’t throw when the hidden-text element is missing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/components/select/select.component.ts | Adds defensive null checks in hidden-items calculation paths to prevent DOM access / Renderer2.setStyle crashes. |
| packages/components/select/select.component.spec.ts | Adds a regression test covering the “hidden-text not yet in DOM” scenario. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace the legacy .eslintrc.js/.eslintignore with a flat eslint.config.js and bump eslint to v9. Swap the unmaintained eslint-plugin-rxjs for the maintained eslint-plugin-rxjs-x fork (rxjs-x/* namespace) and adopt the typescript-eslint and angular-eslint umbrella packages. Preserve the previous lint behavior: disable the rxjs-x rules new to its recommended set (prefer-root-operators, prefer-observer), ignore .yarn (flat config lints .cjs by default), and restore no-unused-vars caughtErrors: 'none'.
…es to option action (#DS-5079)
Drop the align-self: flex-start override that lifted the toggle and checkbox off center. Also center the badge in the tree-action-button example.
lskramarov
force-pushed
the
fix/after-update
branch
from
650aef2 to
fcddba1
Compare
🚨 E2E tests failedReview the report for details. 💡 Comment |
No description provided.