🌱 Plan rung: viewer wording, and the model without its routing envelope - #244
Open
ibolton336 wants to merge 1 commit into
Open
ibolton336 wants to merge 1 commit into
ibolton336 wants to merge 1 commit into
Conversation
Two things a viewer reads on the middle rung, from watching a coolstore run on the ROKS demo cluster: Agent works its standing prompt (us.anthropic.claude-sonnet-4-5-20250929-v1:0, turn 17 of 200) "standing prompt" is our word, not theirs — and it collides with the run's own prompt. CONTEXT.md already calls Agent.spec.prompt "standing instructions for how the agent operates", so the rung now says that. The model is a Bedrock cross-region inference profile id: the geo group, the vendor namespace and the "-v1:0" API version say nothing about which model is answering. modelDisplayName drops those three and keeps identity — name and snapshot date — so the rung reads "claude-sonnet-4-5-20250929". It only touches that dotted shape: a vendor segment comes off only when it is all letters, so "gemini-2.5-pro" and "gpt-4.1" keep their versions, and a path-shaped Vertex ref is left alone. The full id is still on the Gateway the run named and in the pod's KONVEYOR_LLM_MODEL. No changelog fragment: the plan ladder (konveyor#230) is not in alpha.4, so this wording has never been in a release. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: ibolton336 <ibolton@redhat.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What a viewer reads today
Watching a coolstore run on the ROKS demo cluster, the middle rung of the
plan ladder says:
Two problems, both only in the text:
the run's own prompt, which is the thing they might expect to be quoted.
CONTEXT.mdalready definesAgent.spec.promptas "standing instructionsfor how the agent operates", so the rung now uses the glossary's word.
(The quoted-task branch,
Agent works the task: "…", is unchanged.)us.is the cross-region inferenceprofile's geo group,
anthropic.the vendor namespace,-v1:0the APIversion — none of it says which model is answering, and the rung is the only
place a viewer sees the model while a run is going (the console shows it at
Gateway-selection time, not on the run page).
After
modelDisplayNamekeeps the model's identity — the name and the snapshotdate — and drops only the envelope. It is deliberately narrow:
us.anthropic.claude-sonnet-4-5-20250929-v1:0claude-sonnet-4-5-20250929anthropic.claude-3-5-sonnet-20241022-v2:0claude-3-5-sonnet-20241022gemini-2.5-pro,gpt-4.1ai21.jamba-1-5-large-v1:0ai21.jamba-1-5-large— digits in the segment, so the namespace stayspublishers/anthropic/models/…(Vertex)Tradeoff worth a reviewer's eye: the geo prefix is information, and two
profiles that differ only by geo now render identically. I dropped it because
the run already pins one Gateway, whose
spec.model.nameandendpointcarrythe full id, as does the pod's
KONVEYOR_LLM_MODEL. Say the word and I'll keepit.
Wording alternative
If "standing instructions" still reads as ours rather than theirs, the other
candidate is plain
Agent is working— the no-instructions branch has nothingto quote, and the rung already carries the stage, model and turn. I went with
the glossary term because it keeps the distinction between "this run was given
a task" and "it is working from the Agent's own instructions". Easy to switch.
No changelog fragment
The plan ladder itself (#230, merged 2026-09-15) is not in
v0.11.0-alpha.4(cut 2026-09-11) —
planTaskRungdoes not exist in that tag. This wording hastherefore never been in a release, so there is nothing to tell users they need
to un-learn;
230-harness-plan-rung.yamlstill describes the shipped behaviouraccurately.
Verification
cd harness && go test ./...— pass;TestPlanTaskRunggains across-region-Bedrock case (the exact ROKS string above), new
TestModelDisplayNamecovers the table above plus""and a bare"us."go vet ./...,make lint— cleanimage, not this branch.
🤖 Generated with Claude Code