Skip to content

🐛 Prevent AgentWorkflowRun stage initialization race - #243

Open
savitharaghunathan wants to merge 3 commits into
konveyor:mainfrom
savitharaghunathan:evals
Open

savitharaghunathan wants to merge 3 commits into
konveyor:mainfrom
savitharaghunathan:evals

Conversation

@savitharaghunathan

Copy link
Copy Markdown
Member

Summary

  • Prevent an AgentWorkflowRun from being marked failed while a newly created AgentRun is still initializing its status phase.
  • Add controller tests for workflow snapshotting, child-run idempotency, status recovery, and execution-field resolution.
  • Add a Kubernetes E2E restart/reconciliation scenario with a dedicated test-only agent stub image.
  • Document the E2E setup and execution flows.

Fixes #239

Test plan

  • KUBEBUILDER_ASSETS=\"$(pwd)/$(./bin/setup-envtest use 1.36 -p path --bin-dir ./bin)\" go test -count=1 ./...
  • make changelog-validate
  • E2E_NAMESPACE=default E2E_CONTROLLER_NAMESPACE=agentic-controller-system E2E_TIMEOUT_SECONDS=300 ./hack/run-e2e-workflow-reconcile.sh

The full Go suite and restart/reconciliation E2E passed locally.

Assisted-By: Codex <noreply@openai.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Assisted-By: Codex <noreply@openai.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 48267417-fbab-4145-9940-1e27263c6ad2


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@savitharaghunathan savitharaghunathan self-assigned this Sep 17, 2026
Assisted-By: Codex <noreply@openai.com>
Signed-off-by: Savitha Raghunathan <saveetha13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 AgentWorkflowRun status patch races with child AgentRun phase initialization

1 participant