Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pin every third-party Action and reusable workflow to a full commit SHA, and keep those pins current deterministically with pinact — no LLM, no hand-editing 40-char hashes. - Makefile: install pinact (v4.1.1) via the go-install-tool pattern; add pin-actions (pin at current version), update-actions (bump + re-pin), and verify-actions (offline SHA-pinned check, no token). - .pinact.yaml: ignore konveyor first-party refs, which intentionally track main (SHA + '# main', and release-tools/cmd/verify-pr@main). - lint.yml: add an 'actions-pinned' CI job running 'make verify-actions'. - pr-checks.yml: pin actions/checkout@v4 -> SHA (done by pinact). Signed-off-by: David Zager <david.j.zager@gmail.com>
djzager
force-pushed
the
seedling/action-pin-updater
branch
from
August 26, 2026 18:15
a3b2f55 to
ec6c74a
Compare
pinact v4.1.1 requires go >= 1.26.5, but setup-go pins GOTOOLCHAIN=local to the project's go.mod version, so 'go install' refused to build it. Set GOTOOLCHAIN=auto on the verify-actions step so Go fetches the toolchain pinact needs without changing the project's Go version. Signed-off-by: David Zager <david.j.zager@gmail.com>
Member
|
@djzager should this be a part of release-tools repo as well? is there an easy to way to update all the active repos at once? I understand this is out of scope for this issue/pr, but wanted to ask if this can be scaled to other repos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Not urgent — intended to merge after feature freeze. This is CI/toolchain
hygiene, not a feature. Holding until after freeze so it doesn't compete with
in-flight feature work.
What
Give the repo a deterministic way to pin and update the GitHub Actions and
reusable workflows we consume, so keeping SHA pins current never requires
hand-editing 40-char hashes (or asking an LLM to do it).
Uses pinact, installed via the
existing
go-install-toolMakefile pattern.Changes
Makefile: installpinact(v4.1.1); add three targets:make update-actions— bump every third-party Action/reusable workflow tothe latest version and re-pin to a full commit SHA.
make pin-actions— pin any unpinned ref at its current version.make verify-actions— offline check that every ref is SHA-pinned (noGitHub API, no token).
.pinact.yaml: ignore konveyor first-party refs, which intentionallytrack
main(the SHA +# mainpins, andrelease-tools/cmd/verify-pr@main,a bare branch ref that can't be tag-pinned).
.github/workflows/lint.yml: newactions-pinnedjob runningmake verify-actions, so an unpinned action fails CI going forward..github/workflows/pr-checks.yml:actions/checkout@v4→ SHA(
# v4.4.0) — done by pinact, dogfooding the tool.Notes
verify-actionsis offline (-no-api), so the CI check needs no token.update-actionscalls the GitHub API; setGITHUB_TOKENlocally to avoidrate limiting.
:seedling:(CI/toolchain) — no changelog fragment required.