✨ Symlink skills dir for native goose discovery (#70)

[savitharaghunathan]

Assisted-By: Claude Code noreply@anthropic.com

Summary by CodeRabbit

• New Features

  • Skills are now automatically linked into cloned repositories so Goose can discover mounted SkillCard content through its native skill platform.
  • Skill content is progressively disclosed at runtime instead of being embedded in prompts.

• Bug Fixes

  • Improved handling when no skills are available or when skill linking encounters an existing destination.
  • Excluded .agents directories from file watching to prevent unnecessary change detection.

[coderabbitai]

Warning

Review limit reached

@savitharaghunathan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 97a88577-f060-46e5-b30f-cb9ee77888e8

📥 Commits

Reviewing files that changed from the base of the PR and between 7e4bc71 and af474bf.

📒 Files selected for processing (3)

• changes/unreleased/70-skill-symlink-for-goose-discovery.yaml
• harness/cmd/migration-harness/main.go
• harness/cmd/migration-harness/main_test.go

📝 Walkthrough

Walkthrough

The migration harness now discovers skill paths, symlinks them into cloned repositories at .agents/skills, and stops embedding skill content in prompts. Prompt construction always includes working guidelines. The watcher excludes .agents.

Changes

Skill discovery and runtime exposure

Layer / File(s)	Summary
Discover and mount skills harness/cmd/migration-harness/main.go, harness/cmd/migration-harness/main_test.go, harness/internal/watcher/patterns.go, changes/unreleased/...	Skill discovery returns paths instead of file contents. The harness creates .agents/skills symlinks and handles existing destinations and discovery errors. Watchers exclude .agents. Tests and the changelog cover the new behavior.
Remove prompt skill injection harness/internal/prompt/prompt.go, harness/internal/prompt/prompt_test.go, harness/cmd/migration-harness/main.go	Layers no longer contains Skill. Prompt construction always adds working guidelines and the commit instruction. Tests remove skill-layer expectations.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Harness as migration-harness
  participant Discovery as discoverSkills
  participant Symlink as symlinkSkillsDir
  participant Repository as cloned repository
  Harness->>Discovery: discover SKILL.md paths
  Discovery-->>Harness: return skill paths
  Harness->>Symlink: mount discovered skills
  Symlink->>Repository: create .agents/skills symlink

Loading

Possibly related PRs

• konveyor/agentic-controller#4: Provisions and validates skills mounted under /opt/skills.
• konveyor/agentic-controller#83: Modifies harness skill discovery and runtime behavior.
• konveyor/agentic-controller#84: Introduces the prompt skill-layer handling replaced by this change.

Suggested reviewers: fabianvf

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description contains only an attribution and the commented template, without an actual change summary or required changelog information.	Add a concise PR summary and state that the required changelog fragment was added for this feature change.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title uses the required feature alias and clearly describes symlinking the skills directory for native Goose discovery.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@changes/unreleased/70-skill-symlink-for-goose-discovery.yaml`:
- Around line 3-4: Update the change description to document that the symlink
target is configurable through HARNESS_SKILLS_DIR, with /opt/skills identified
as the default target.

In `@harness/cmd/migration-harness/main.go`:
- Around line 373-378: Update symlinkSkillsDir in
harness/cmd/migration-harness/main.go:373-378 to reject a repository-controlled
symlinked .agents directory before MkdirAll or Symlink can write outside
cloneDir, and convert relative skillsSrc values to an absolute path with
filepath.Abs so the link target matches discovery resolution. Add coverage in
harness/cmd/migration-harness/main_test.go:66-96 for both rejecting the .agents
symlink and resolving relative HARNESS_SKILLS_DIR values.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 17260f9c-899e-4a3c-98ed-e592706afbe0

📥 Commits

Reviewing files that changed from the base of the PR and between 72f126d and 7e4bc71.

📒 Files selected for processing (6)

• changes/unreleased/70-skill-symlink-for-goose-discovery.yaml
• harness/cmd/migration-harness/main.go
• harness/cmd/migration-harness/main_test.go
• harness/internal/prompt/prompt.go
• harness/internal/prompt/prompt_test.go
• harness/internal/watcher/patterns.go