Skip to content

fix(skills): marketplace setup incorrectly reports error after successful clone #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kolatts merged 1 commit into from
Jun 30, 2026
Merged

fix(skills): marketplace setup incorrectly reports error after successful clone #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/services/skills/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,20 @@ export function registerSkillsCommands(program: Command): void {
try {
execFileSync('git', cloneArgs, { stdio: ['inherit', 'inherit', 'pipe'] });
} catch (e: unknown) {
const msg = e instanceof Error ? e.message : String(e);
throw new Error(msg.replace(/x-(?:token-auth|access-token):[^@]+@/g, 'x-token-auth:***@'));
// On some platforms (e.g. Windows with Git Credential Manager), git may
// write authentication warnings to stderr and exit non-zero even though
// the clone was successfully written to disk. Verify by running
// `git rev-parse HEAD` at the destination; if that succeeds the repo is
// valid and we continue rather than surfacing a spurious error.
let cloneActuallySucceeded = false;
try {
execFileSync('git', ['-C', resolvedPath, 'rev-parse', 'HEAD'], { stdio: 'pipe' });
cloneActuallySucceeded = true;
} catch { /* repo not valid — fall through and re-throw original error */ }
if (!cloneActuallySucceeded) {
const msg = e instanceof Error ? e.message : String(e);
throw new Error(msg.replace(/x-(?:token-auth|access-token):[^@]+@/g, 'x-token-auth:***@'));
}
Comment on lines +271 to +279

@claude claude Bot Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boolean flag can be eliminated — re-throw inside the inner catch instead:

Suggested change
let cloneActuallySucceeded = false;
try {
execFileSync('git', ['-C', resolvedPath, 'rev-parse', 'HEAD'], { stdio: 'pipe' });
cloneActuallySucceeded = true;
} catch { /* repo not valid — fall through and re-throw original error */ }
if (!cloneActuallySucceeded) {
const msg = e instanceof Error ? e.message : String(e);
throw new Error(msg.replace(/x-(?:token-auth|access-token):[^@]+@/g, 'x-token-auth:***@'));
}
try {
execFileSync('git', ['-C', resolvedPath, 'rev-parse', 'HEAD'], { stdio: 'pipe' });
} catch {
// rev-parse failed — repo is not valid, surface the original clone error
const msg = e instanceof Error ? e.message : String(e);
throw new Error(msg.replace(/x-(?:token-auth|access-token):[^@]+@/g, 'x-token-auth:***@'));
}

Same semantics, one less variable, easier to read at a glance.

@kolatts kolatts Jun 30, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claude[agent] fix this

}
}

Expand Down
Loading