pncli skills marketplace setup incorrectly states error after successful clone

[kolatts]

pncli skills marketplace setup https:///scm/~/skills-marketplace.git

Cloning https:///scm/~/skills-marketplace.git (branch: remote default) → C:\Users<user-id>.agents\marketplaces\skills-marketplace...

{
"ok": false,
"error": {
"status": 1,
"message": "Command failed: git clone https:///scm//skills-marketplace.git C:\Users\\.agents\marketplaces\skills-marketplace\nCloning into 'C:\Users\\.agents\marketplaces\skills-marketplace'...\nfatal: Authentication failed for 'https:///scm//skills-marketplace.git/'\n",
"url": null
},
"meta": {
"service": "skills",
"action": "marketplace-setup",
"timestamp": "2026-06-30T12:47:09.038Z",
"duration_ms": 1131,
"user": {
"email": "",
"userId": ""
}
}
}

Service: Git

---

Submitted via kolatts.github.io/pncli

[claude]

Claude finished @kolatts's task in 11m 39s —— View job • claude/issue-239-20260630-1250

---

Analysis

The bug is in src/services/skills/commands.ts in the marketplace setup action. When git clone exits non-zero, the current code immediately re-throws the error and reports ok: false:

try {
  execFileSync('git', cloneArgs, { stdio: ['inherit', 'inherit', 'pipe'] });
} catch (e: unknown) {
  const msg = e instanceof Error ? e.message : String(e);
  throw new Error(msg.replace(...));  // ← always throws, even if clone actually worked
}

On Windows with Git Credential Manager, git can write authentication warnings/errors to stderr and exit non-zero even though the repository was successfully written to disk (e.g. an initial credential exchange fails but GCM retries and the clone succeeds, yet git's exit code reflects the initial failure). The code never checks whether a valid repo exists, so it surfaces the error unconditionally.

Fix

After execFileSync throws, run git rev-parse HEAD at the destination. If that succeeds, the clone is valid and the command continues. If not, the original error is re-thrown as before.

try {
  execFileSync('git', cloneArgs, { stdio: ['inherit', 'inherit', 'pipe'] });
} catch (e: unknown) {
  let cloneActuallySucceeded = false;
  try {
    execFileSync('git', ['-C', resolvedPath, 'rev-parse', 'HEAD'], { stdio: 'pipe' });
    cloneActuallySucceeded = true;
  } catch { /* repo not valid — fall through and re-throw original error */ }
  if (!cloneActuallySucceeded) {
    const msg = e instanceof Error ? e.message : String(e);
    throw new Error(msg.replace(/x-(?:token-auth|access-token):[^@]+@/g, 'x-token-auth:***@'));
  }
}

Checklist

• Read CLAUDE.md and understand project rules
• Check for duplicate issues (none found)
• Locate marketplace setup source code
• Assess feasibility and root cause
• Implement fix (src/services/skills/commands.ts)
• Run typecheck, lint, and tests (295 tests pass)
• Commit, push, and open PR

Implemented in PR: #242

After execFileSync throws for the clone, the fix runs git rev-parse HEAD at the destination to verify whether a valid repository actually exists. If it does, the command continues normally instead of surfacing a spurious error. If the repo is genuinely absent, the original git error is re-thrown as before.
·