Skip to content

cherry pick #4794 for release 4.3.0 #4795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leebrouse wants to merge 1 commit into
base: release-4.3.0
Choose a base branch
from
Open

cherry pick #4794 for release 4.3.0 #4795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkg/microservice/aslan/core/common/service/workflowcontroller/jobcontroller/job_apisix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,17 @@ func convertToProto(spec interface{}) (*apisix.Proto, error) {
return nil, fmt.Errorf("failed to unmarshal to proto: %v", err)
}

// bug point dont touch it!
// if delete it , proto in apisix will fail to run
if proto.Name == "" {
proto.Desc = proto.ID
proto.Name = proto.ID
return proto, nil
}

proto.Desc = proto.Name
proto.ID = proto.Name

return proto, nil
}

Expand Down
Loading