Skip to content

Captioning & lyrics provider fixes and improvements - #63

Open
scragnog wants to merge 3 commits into
koda-dernet:mainfrom
scragnog:pr/caption-lyrics
Open

Captioning & lyrics provider fixes and improvements#63
scragnog wants to merge 3 commits into
koda-dernet:mainfrom
scragnog:pr/caption-lyrics

Conversation

@scragnog

Copy link
Copy Markdown

Captioning & lyrics provider fixes and improvements

Gemini/OpenAI masked-key fix. The frontend receives masked API keys (••••aldc, Unicode bullets) from /api/settings for display. When a caption task echoed one back, httpx rejected the non-ASCII x-goog-api-key header with an opaque encoding error. Task manager now detects masked/empty keys and falls back to the real key from settings.json or env — the same pattern already used for the HF token.

Genius lyrics provider. Search reliability was poor for anything that wasn't an exact title match:

local_12gb caption tier. New local captioner tier loads the model 8-bit (BitsAndBytes) for 12 GB GPUs, surfaced in GUI, wizard and CLI. The local captioner also resolves model weights from the configured checkpoint dir before falling back to the HF cache.

🤖 Generated with Claude Code

Rob Work PC and others added 3 commits July 29, 2026 11:30
The frontend receives masked keys ('••••aldc', Unicode bullets) for
display; when a caption task echoed one back, httpx rejected the
non-ASCII x-goog-api-key header. Detect masked/empty keys and fall back
to the real key from settings.json or env (same pattern already used
for the HF token).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- _clean_search_title/_clean_search_artist strip noise (feat., remaster
  tags, bracketed suffixes) before querying
- artist/title swap retry when the first search misses
- _titles_match fuzzy validation rejects wrong-song hits
- _is_profile_page markers reject artist-profile pages returned as songs
- keeps the lyricsgenius>=3.6 compatibility fix from koda-dernet#47 (no verbose
  kwarg; logger silenced instead)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…eckpoint dir

- new local_12gb provider tier loads the local captioner in 8-bit
  BitsAndBytes for 12 GB GPUs (from 1fe7c70, Gabriel's work)
- local captioner resolves model weights from the configured checkpoint
  dir before falling back to the HF cache

Co-authored-by: Gabriel <gadna166@gmail.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@scragnog, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6c8c2016-733e-4195-9658-6e1b1086982c

📥 Commits

Reviewing files that changed from the base of the PR and between ecd13bd and e3c37fa.

📒 Files selected for processing (9)
  • frontend/index.html
  • frontend/js/workspace-lab.js
  • sidestep_engine/cli/args.py
  • sidestep_engine/data/caption_provider_local.py
  • sidestep_engine/data/lyrics_provider_genius.py
  • sidestep_engine/gui/task_manager.py
  • sidestep_engine/ui/flows/build_dataset_ai.py
  • sidestep_engine/ui/flows/build_dataset_ai_batch.py
  • train.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@scragnog
scragnog marked this pull request as ready for review July 29, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant