Skip to content

feat: knock test emails only go to account members#1457

Open
cjbell wants to merge 5 commits into
mainfrom
cjbell-kno-13362-docs-update-knock-test-email-documentation
Open

feat: knock test emails only go to account members#1457
cjbell wants to merge 5 commits into
mainfrom
cjbell-kno-13362-docs-update-knock-test-email-documentation

Conversation

@cjbell
Copy link
Copy Markdown
Contributor

@cjbell cjbell commented May 27, 2026

Description

Limit Knock test channel to send to members of the account only

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 27, 2026

KNO-13362

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment May 28, 2026 8:03pm

Request Review

cursor[bot]
cursor Bot approved these changes May 27, 2026 •
edited
Loading
View reviewed changes
cellomatt
cellomatt approved these changes May 27, 2026
View reviewed changes
Comment thread content/integrations/email/knock-test.mdx Outdated
@cjbell @cellomatt
Apply suggestions from code review
f6976aa 
Co-authored-by: Matt Kufchak <matt.kufchak@gmail.com>
rachael-t
rachael-t approved these changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@rachael-t rachael-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added suggestions about maybe adding links to the manage account members docs for additional clarity, but open to leaving them out.

Comment thread content/integrations/email/knock-test.mdx Outdated
Comment thread content/integrations/email/knock-test.mdx Outdated
Comment thread content/integrations/email/knock-test.mdx Outdated
@cjbell @rachael-t
Apply suggestions from code review
afa8248 
Co-authored-by: Rachael Thomas <54180641+rachael-t@users.noreply.github.com>
cursor[bot]
cursor Bot reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit afa8248. Configure here.

Comment thread content/integrations/email/knock-test.mdx Outdated
@cjbell
Copy link
Copy Markdown
Contributor Author

cjbell commented May 28, 2026

@cursor fix the issues here please

@cursor
Copy link
Copy Markdown

cursor Bot commented May 28, 2026 •
edited
Loading

Implemented the review fix for content/integrations/email/knock-test.mdx: the callout now uses a JSX <a> link so “members” renders as a clickable link inside the Callout text prop. Committed and pushed as 88902373.

Validated with:

  • yarn prettier --check content/integrations/email/knock-test.mdx
  • yarn build
  • Browser test confirming the callout link navigates to the managing members page

Open in Web Open in Cursor 

@cjbell cjbell force-pushed the cjbell-kno-13362-docs-update-knock-test-email-documentation branch from 8890237 to 109ff97 Compare May 28, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] approved these changes

@rachael-t rachael-t rachael-t approved these changes

@cellomatt cellomatt cellomatt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cjbell @rachael-t @cellomatt