This repository was archived by the owner on Apr 27, 2026. It is now read-only.
fix(astro-markflow): handle single-line getHeadings in RE_SCAN_NOISE regex - #174
Closed
jp-knj wants to merge 1 commit into
Closed
fix(astro-markflow): handle single-line getHeadings in RE_SCAN_NOISE regex#174jp-knj wants to merge 1 commit into
jp-knj wants to merge 1 commit into
Conversation
…regex The getHeadings branch in RE_SCAN_NOISE expected multi-line format with `\n}` on its own line. For single-line output from blocksToJsx/wrapHtmlInJsxModule, `[\s\S]*?\n}` would scan past the closing `}` and match the next `\n}` in the file, stripping the entire JSX body and silently dropping component imports. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jp-knj
force-pushed
the
fix/scan-noise-single-line-getheadings
branch
from
February 1, 2026 16:35
c8d9dfd to
689779b
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Member
Author
|
Merged into #173 (perf/vite-plugin-reduce-redundant-work). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RE_SCAN_NOISEregex that over-matched single-linegetHeadings()output, stripping the entire JSX body and silently dropping component importsgetHeadingsbranch now uses an alternation to handle both single-line ({ return [...]; }\n) and multi-line ({\n return [...];\n}\n) formatsgetHeadingsscanningTest plan
pnpm --dir packages/astro-markflow test)getHeadingsis stripped without affecting component detection🤖 Generated with Claude Code