feat: knighted css imports.#139
Merged
knightedcodemonkey merged 3 commits intomainfrom May 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for ?knighted-css (and &combined) query imports in workspace tabs so modules (or style tabs) can be imported with additional exports containing compiled CSS text (and optionally re-exporting the target module).
Changes:
- Extend style compilation output to include a per-style-tab compiled CSS map (
styleCssByTabId) and pass it into virtual module planning. - Add virtual module rewriting for
?knighted-cssquery imports, producing data-URL modules that exportknightedCss/knightedCssModules(and optionally the target module exports viacombined). - Document the query import feature in the README and add Playwright coverage for query imports.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/modules/preview/render-runtime.js | Tracks compiled CSS per style tab and forwards it to the virtual module planner. |
| src/modules/preview-runtime/virtual-workspace-modules.js | Parses query flags and rewrites imports to generate ?knighted-css query modules (including combined). |
| README.md | Documents ?knighted-css and &combined workspace import patterns and expected exports. |
| playwright/rendering-modes/core.spec.ts | Adds E2E tests validating ?knighted-css behavior for module and style tab imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.