Skip to content

fix: Fail on start() instead of silent ignore; encode string during error returns #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
May 6, 2026
+16 −4
Merged

fix: Fail on start() instead of silent ignore; encode string during error returns #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/func_python/cloudevent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,13 @@ async def __call__(self, scope, receive, send):
while True:
message = await receive()
if message['type'] == 'lifespan.startup':
await self.on_start()
try:
await self.on_start()
except Exception as e:
logging.error("function startup failed: %s", e)
await send({'type': 'lifespan.startup.failed',
'message': str(e)})
return
await send({'type': 'lifespan.startup.complete'})
elif message['type'] == 'lifespan.shutdown':
await self.on_stop()
Expand Down Expand Up @@ -253,7 +259,7 @@ async def send_exception(send, code, message):
'headers': [[b'content-type', b'text/plain']],
})
await send({
'type': 'http.response.body', 'body': message,
'type': 'http.response.body', 'body': message.encode('utf-8') if isinstance(message, str) else message,
})


Expand Down
10 changes: 8 additions & 2 deletions src/func_python/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,13 @@ async def __call__(self, scope, receive, send):
while True:
message = await receive()
if message['type'] == 'lifespan.startup':
await self.on_start()
try:
await self.on_start()
except Exception as e:
logging.error("function startup failed: %s", e)
await send({'type': 'lifespan.startup.failed',
'message': str(e)})
return
await send({'type': 'lifespan.startup.complete'})
elif message['type'] == 'lifespan.shutdown':
await self.on_stop()
Expand Down Expand Up @@ -186,5 +192,5 @@ async def send_exception(send, code, message):
'headers': [[b'content-type', b'text/plain']],
})
await send({
'type': 'http.response.body', 'body': message,
'type': 'http.response.body', 'body': message.encode('utf-8') if isinstance(message, str) else message,
})
Loading