Skip to content

fix(terminal): require touch slop before starting finger scroll #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itsvks19 merged 1 commit into from
Aug 31, 2026
Merged

fix(terminal): require touch slop before starting finger scroll #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions terminal/src/main/kotlin/com/klyx/terminal/ui/Terminal.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,19 +539,20 @@ private fun Modifier.scroll(
state.scrolledWithFinger.value = true

var previousPosition = down.position
var passedTouchSlop = false

do {
val event = awaitPointerEvent()
val dragEvent = event.changes.firstOrNull { it.id == down.id } ?: break
if (!dragEvent.pressed) break

val dragAmount = dragEvent.position - previousPosition
previousPosition = dragEvent.position

if (selectionState.isActive) {
// Handles own their own drag; nothing to do here for plain scroll.
// Edge-auto-scroll is handled inside each handle's onDragPosition.
} else {
previousPosition = dragEvent.position
} else if (passedTouchSlop) {
val dragAmount = dragEvent.position - previousPosition
previousPosition = dragEvent.position
dragEvent.consume()

state.scrolledWithFinger.value = true
Expand All @@ -566,6 +567,9 @@ private fun Modifier.scroll(
fontMetrics
)
}
} else if ((dragEvent.position - down.position).getDistance() > viewConfiguration.touchSlop) {
passedTouchSlop = true
previousPosition = dragEvent.position
}
} while (true)

Expand Down