Skip to content

fix: fail loudly if generated format files can't be formatted #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dogmar merged 1 commit into from
Jun 14, 2026
Merged

fix: fail loudly if generated format files can't be formatted #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions package/scripts/generate-formats.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,13 +318,12 @@ for (const format of formats) {
console.log(` wrote src/formats/${kebab}.ts`);
}

// Run linting and formatting on generated files using vp's bundled toolchain
// so output matches `vp fmt` / `vp check --fix` behavior everywhere.
console.log("Running linter and formatter...");
try {
execSync(`npx vp check --fix ${FORMATS_DIR}`, { cwd: ROOT, stdio: "pipe" });
} catch {
// vp check --fix may exit non-zero for unfixable issues; that's OK
}
// Format the generated files in place with vp's bundled oxfmt (the raw output
// has unwrapped imports). This must succeed: the sync-generated CI workflow
// commits whatever this writes, so a swallowed failure would land unformatted
// files on main. Fail loudly instead. Lint/typecheck correctness is enforced
// separately by the `ready` gate, so formatting is all that's needed here.
console.log("Formatting generated files...");
execSync(`npx vp fmt ${FORMATS_DIR}`, { cwd: ROOT, stdio: "inherit" });

console.log("Done.");
Loading