chore(release): 6.1.0 - #72
Merged
Merged
Conversation
A minor for one addition: `DeclaredContributions.keybindings`, which makes `assertManifestMatches` check that every contributed keybinding binds a command the extension declares. Omitting the field checks nothing, so nothing changes for an existing caller. Trialled in quick-utils before tagging, from a packed tarball: the extension's own hand-written version of this check was removed in favour of the option, and the replacement caught both ways that check exists to catch -- a typo in a bound command and a rename left behind in the manifest. `vsce package` produced a VSIX and the real Extension Host passed its 13 cases. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor for one addition:
DeclaredContributions.keybindings, which makesassertManifestMatchescheck that every contributed keybinding binds a command theextension declares. Omitting the field checks nothing, so nothing changes for an existing
caller.
Trialled before tagging
Packed to a tarball and installed into quick-utils as a
file:dependency. Theextension's own hand-written version of this check — it asserted that menus and
keybindings reference only declared commands — was cut down to menus alone, with the
keybinding half handed to the option.
Then the replacement was broken on purpose, because a test that was not seen to fail has
not been seen to work:
keybinding "quickUtils.transformX" is bound in contributes.keybindings but no contract declares it…keybinding "quickUtils.transformAgainRenamed" …typecheck,lint,check:l10ncleanvsce packageproduced a VSIXallowturned out not to be needed — every key quick-utils binds is its own command,which is the case the default is built for
Not changed as a result
The trial surfaced one gap and it is deliberately left open:
contributes.menusentriesreference commands the same way and are still the consumer's to check. quick-utils keeps
that half. Widening the option to menus is easy later; narrowing it would not be.
🤖 Generated with Claude Code