Remove OpenResty override#808
Merged
Merged
Conversation
atodorov
force-pushed
the
remove_openresty
branch
6 times, most recently
from
d73f796 to
b0d8087
Compare
b/c package is outdated. Will rate-limit via NGINX itself. NOTE: original rate-limiting for pages which generate errors didn't work quite as expected and it also doesn't work with vanilla NGINX b/c limit_req isn't processed inside an internal redirect (i.e. named location). What we need to do is inside the named location handler (or a custom error_page handler) add the limit key to the zone itself so that a subsequent request will be blocked and not processed further!
atodorov
force-pushed
the
remove_openresty
branch
from
b0d8087 to
6d469e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/c package is outdated. Rate-limit via NGINX itself.