fix: drop the unused power-of-ten rarity helper - #856
Closed
kitsuyui wants to merge 1 commit into
Closed
Conversation
Remove the dead PR rarity helper and its dedicated test so the maintained code, coverage accounting, and published dist surface reflect the rules that are still reachable in production.
🎉 Happy commit!
|
gh-counterPR gate
Repo dashboard
Reported by gh-counter |
Code Metrics Report
Details | | main (731d7b7) | #856 (3a8ff0f) | +/- |
|---------------------|----------------|----------------|-------|
- | Coverage | 97.1% | 97.0% | -0.1% |
| Files | 7 | 7 | 0 |
| Lines | 177 | 171 | -6 |
- | Covered | 172 | 166 | -6 |
+ | Code to Test Ratio | 1:1.5 | 1:1.6 | +0.0 |
| Code | 780 | 771 | -9 |
- | Test | 1241 | 1234 | -7 |
| Test Execution Time | 2s | 2s | 0s |Code coverage of files in pull request scope (100.0% → 100.0%)
Reported by octocov |
Owner
Author
|
This pull request was created by an automated implementation attempt, but it did not satisfy the implementation contract and has been closed automatically. Reason: implementation must record planning_contract_version 2 |
gh-build-size
Reported by gh-build-size |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expectedPowersOfTenhelper and its dedicated test coveragedist/rarity.*so the published artifact matches the source cleanupWhy
The production rules only use
expectedSingleNonzeroDigitPrNumbers, so keepingexpectedPowersOfTenand a test that exists only for that helper makes the code inventory and coverage totals look larger than the maintained runtime surface.Validation
bun run lintbun run testbun run build