Skip to content

fix: drop the unused power-of-ten rarity helper - #856

Closed
kitsuyui wants to merge 1 commit into
mainfrom
fix/metric-audit-002
Closed

fix: drop the unused power-of-ten rarity helper#856
kitsuyui wants to merge 1 commit into
mainfrom
fix/metric-audit-002

Conversation

@kitsuyui

@kitsuyui kitsuyui commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove the unused expectedPowersOfTen helper and its dedicated test coverage
  • regenerate dist/rarity.* so the published artifact matches the source cleanup

Why

The production rules only use expectedSingleNonzeroDigitPrNumbers, so keeping expectedPowersOfTen and a test that exists only for that helper makes the code inventory and coverage totals look larger than the maintained runtime surface.

Validation

  • bun run lint
  • bun run test
  • bun run build

Remove the dead PR rarity helper and its dedicated test so the maintained code, coverage accounting, and published dist surface reflect the rules that are still reachable in production.
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🎉 Happy commit!

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

gh-counter

PR gate

Removed Added +/-
TODO/FIXME 0 0 0

Repo dashboard

main (731d7b7) #856 (3a8ff0f) +/-
TODO/FIXME 0 0 0

Reported by gh-counter

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Code Metrics Report

main (731d7b7) #856 (3a8ff0f) +/-
Coverage 97.1% 97.0% -0.1%
Code to Test Ratio 1:1.5 1:1.6 +0.0
Test Execution Time 2s 2s 0s
Details
  |                     | main (731d7b7) | #856 (3a8ff0f) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          97.1% |          97.0% | -0.1% |
  |   Files             |              7 |              7 |     0 |
  |   Lines             |            177 |            171 |    -6 |
- |   Covered           |            172 |            166 |    -6 |
+ | Code to Test Ratio  |          1:1.5 |          1:1.6 |  +0.0 |
  |   Code              |            780 |            771 |    -9 |
- |   Test              |           1241 |           1234 |    -7 |
  | Test Execution Time |             2s |             2s |    0s |

Code coverage of files in pull request scope (100.0% → 100.0%)

Files Coverage +/- Status
src/rarity.ts 100.0% 0.0% modified

Reported by octocov

@kitsuyui

kitsuyui commented Aug 3, 2026

Copy link
Copy Markdown
Owner Author

This pull request was created by an automated implementation attempt, but it did not satisfy the implementation contract and has been closed automatically.

Reason: implementation must record planning_contract_version 2

@kitsuyui kitsuyui closed this Aug 3, 2026
@kitsuyui
kitsuyui deleted the fix/metric-audit-002 branch August 3, 2026 21:06
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

gh-build-size

Target main #856 +/-
Total action artifacts 23,303,031 B 23,302,275 B -756 B
Runtime bundle 1,153,987 B 1,153,904 B -83 B
Source maps 17,133,019 B 17,132,428 B -591 B
Type declarations 4,973,956 B 4,973,874 B -82 B

Reported by gh-build-size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant