[MAINTENANCE] Adjust countings statistics for collections and add tests#1988
Open
beatrycze-volk wants to merge 3 commits into
Open
[MAINTENANCE] Adjust countings statistics for collections and add tests#1988beatrycze-volk wants to merge 3 commits into
beatrycze-volk wants to merge 3 commits into
Conversation
The `getStatisticsForSelectedCollection` method is made more robust by checking for the existence of the 'collections' key using `array_key_exists`. Functional tests are added to verify its behavior for various collection selection scenarios.
Replaces a duplicated QueryBuilder implementation with a call to the existing `count` method. This ensures consistent application of counting logic and improves code maintainability.
Extracts logic for counting document statistics into new, dedicated private methods. This improves readability and reduces the complexity of the `getStatisticsForSelectedCollection` method by delegating distinct calculation scenarios (selected collections vs. all collections) to separate functions.
beatrycze-volk
added
the
⟳ maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.