Warn before reusing a keyboard shortcut that's already taken - #446
Merged
Merged
Conversation
jvanderen1
marked this pull request as ready for review
September 13, 2026 05:30
Owner
|
This doesn’t build as it seems to depend on changes in your other pending PRs. Either need to rebase directly on main or we need to get through the other PRs first. I had replied to the one in the queue a few days back I believe. |
Recording a chord that another action already owns used to succeed silently, so users couldn't tell who held a shortcut or that the old binding would disappear. Co-authored-by: Cursor <cursoragent@cursor.com>
A hardcoded list of menu selectors would drift whenever a new File or View shortcut is added; clearing MenuShortcutState during capture lets the editor see the physical chord from the live binding table instead. Co-authored-by: Cursor <cursoragent@cursor.com>
Stealing a chord used to leave a stale remap or wipe the new binding; the old action now stays unbound and the new one keeps the shortcut. Co-authored-by: Cursor <cursoragent@cursor.com>
The editor API on main already takes a profile parameter and a single-argument outcome; restore those so this branch builds without the mux PRs.
jvanderen1
force-pushed
the
feat/keybind-conflict-override
branch
from
September 13, 2026 17:45
281569d to
f4b8d80
Compare
Contributor
Author
|
I just fixed this PR. Will take a look at your comment on #433. Thanks! |
Require switch-aware parents for in-sheet action changes. Check new profile shortcuts against existing profiles and persist targeted unbinds for displaced parameterized bindings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
⌘Treach the editor. Conflict checks use the live binding table.⌘.still uses the reserved Send Escape menu item.Test plan
⌘Twhile New Tab owns it) — Shortcut Already in Use, not a new tab.Screencast
Update.Shortcuts-gh.mp4