Fix mux tab close after detach/reattach (#407) - #431
Open
jvanderen1 wants to merge 6 commits into
Open
jvanderen1 wants to merge 6 commits into
jvanderen1 wants to merge 6 commits into
Conversation
8 tasks
jvanderen1
force-pushed
the
feature/407-2-mux-close-semantics
branch
2 times, most recently
from
September 13, 2026 21:20
8af4c7b to
36b7a98
Compare
Leave a mux session running from Tabs / the tab menu, focus a live auto-start attachment instead of opening a second client, and offer Reconnect on a short banner. Raw-pane chords use swipe discovery when present, otherwise the usual defaults.
jvanderen1
force-pushed
the
feature/407-2-mux-close-semantics
branch
from
September 13, 2026 21:27
36b7a98 to
aef83ee
Compare
herdr (control) is a gateway plus projected tabs, not a raw pane binding. Match HerdrController the same way tmux -CC matches TmuxController, and do not treat a leftover gateway shell as still attached.
3 tasks
jvanderen1
marked this pull request as ready for review
September 16, 2026 02:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requestKillWindow(does not require a live pane in the tab tree)Depends on / merge after: #430 (this branch now includes current #430, including the herdr control-mode resume commit and the main merge). Review the unique commit for the close-after-reattach change — two files:
TmuxController.swift,MainView+TabManagement.swift.Part of #407. Stack: PR 2 of 3. Still required after #430: that PR does not include the tombstone /
requestKillWindowpath, so reattached background tmux windows still no-op or self-heal on ✕.#432 is optional and is not needed to land this.
Screencast
Same DietPi recording as #430 — no separate take. Watch the close/kill beats here; detach/resume is #430.
Different.Multiplexers-gh.mp4
This PR (after #430 detach → reconnect)
Last herdr tab ✕ ending the session may appear later in the same recording; that is local follow-up, not this diff.
Test plan