Fix typo in the remote_private_key error message - #27
Open
branchard wants to merge 1 commit into
Open
Conversation
davisagli
requested changes
Sep 9, 2026
| fi | ||
| if [[ -z "${REMOTE_PRIVATE_KEY}" ]]; then | ||
| echo "Input private_key is required!" | ||
| echo "Input remote_private_key is required!" |
Member
There was a problem hiding this comment.
Suggested change
| echo "Input remote_private_key is required!" | |
| echo "Input REMOTE_PRIVATE_KEY is required!" |
Author
There was a problem hiding this comment.
All other input names are lowercase in error messages, like Input stack_file is required! or Input remote_host is required!.
| run_entrypoint REMOTE_HOST=swarm.example.com REMOTE_USER=deploy | ||
| [ "$status" -eq 1 ] | ||
| [[ "$output" == *"Input private_key is required!"* ]] | ||
| [[ "$output" == *"Input remote_private_key is required!"* ]] |
Member
There was a problem hiding this comment.
Suggested change
| [[ "$output" == *"Input remote_private_key is required!"* ]] | |
| [[ "$output" == *"Input REMOTE_PRIVATE_KEY is required!"* ]] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a small typo. The error message shown when
remote_private_keyis missing referencedprivate_keyinstead of the actual input name, which was confusing when troubleshooting a missing input.