Skip to content

Updated Highcharts from 6.0.4 to 7.0.2#433

Open
noumanaltaf wants to merge 4 commits into
kirjs:masterfrom
noumanaltaf:emumba_react-highcharts
Open

Updated Highcharts from 6.0.4 to 7.0.2#433
noumanaltaf wants to merge 4 commits into
kirjs:masterfrom
noumanaltaf:emumba_react-highcharts

Conversation

@noumanaltaf

Copy link
Copy Markdown

Highcharts version updated from 6.0.4 to 7.0.2
And also updated package name to avoid name conflict on npm.
Suggestion : Please move highcharts from dependencies to peer dependencies to minimize scenarios like this.

@pascalgn

Copy link
Copy Markdown

I would also be interested in this! If you need any help or support, just let me know! 👍

@pascalgn

pascalgn commented Mar 6, 2019

Copy link
Copy Markdown

I just had a closer look at this PR again and it looks to be in a very early stage, for example some files are added that should not be added. @noumanaltaf are you still working on this?

@inoyakaigor inoyakaigor mentioned this pull request Sep 11, 2019
@riiniii

riiniii commented Apr 21, 2020

Copy link
Copy Markdown

how do we update this? trying to update to version 8

@murb

murb commented Jun 10, 2020

Copy link
Copy Markdown

this isn't a clean upgrade path. This pull request should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants