Feature/lab 4425 aau i can filter on the sdk using group name#2048
Open
RuellePaul wants to merge 3 commits into
Open
Feature/lab 4425 aau i can filter on the sdk using group name#2048RuellePaul wants to merge 3 commits into
RuellePaul wants to merge 3 commits into
Conversation
Add group_name: Optional[list[str]] parameter to kili.assets(), kili.count_assets(), kili.labels(), kili.count_labels(), kili.export_labels(), and kili.llm.export(). Thread it through AssetFilters, asset_where_mapper (groupName), and check_asset_workflow_arguments (reject on WorkflowV1).
Add unit tests for: group_name forwarding via AssetsNamespace.list/count, asset_where_mapper groupName field, and check_asset_workflow_arguments rejecting group_name on V1 / accepting on V2.
Add missing asset_group_name to labels() implementation body (two overloads and the @TypeChecked function were missing the parameter and its wiring into AssetFilters / check_asset_workflow_arguments).
| ) | ||
| if group_name is not None: | ||
| raise ValueError( | ||
| "Filter group_name given : group_name is only applicable to WorkflowV2 projects." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.