refactor: return an integer from Inspector:getId - #81
Open
chernetskyi wants to merge 1 commit into
Open
chernetskyi wants to merge 1 commit into
chernetskyi wants to merge 1 commit into
Conversation
Both call sites feed the result straight into a '%d' format, so the id was converted to a string only for string.format to convert it back. ids already holds integers. The round trip relied on Lua's automatic string to number coercion, which is absent from an interpreter built with LUA_NOCVTS2N. It also made 'tl check' report the two call sites as passing a string where an integer is expected; both of those errors are now gone. The format strings are unchanged and so is the rendered output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both call sites feed the result straight into a '%d' format, so the id was converted to a string only for string.format to convert it back. ids already holds integers.
The round trip relied on Lua's automatic string to number coercion, which is absent from an interpreter built with LUA_NOCVTS2N. It also made 'tl check' report the two call sites as passing a string where an integer is expected; both of those errors are now gone.
The format strings are unchanged and so is the rendered output.