Conversation
The _VERSION constant still reported 3.1.0 even though 3.1.1, 3.1.2 and 3.1.3 have been released. Sync it to the current release and add a spec that guards the value. Fixes kikito#79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79.
inspect._VERSIONstill reportedinspect.lua 3.1.0even though 3.1.1, 3.1.2 and 3.1.3 have been released (the CHANGELOG, tags and rockspecs all list 3.1.3). Anyone readinginspect._VERSIONgot a stale number.Fix: bump the constant in
inspect.tltoinspect.lua 3.1.3and regenerateinspect.luawithtl genso the generation check stays green.Test: added a small spec asserting
inspect._VERSION == 'inspect.lua 3.1.3'.Validation (Lua 5.4, local):
tl gen inspect.tl→ regenerated; a secondtl genproduces an identical file (generation check passes)luacheck inspect.lua→ 0 warnings / 0 errorsbusted→ 50 successes / 0 failures3.1.0and regenerating makes the new spec fail (expected 'inspect.lua 3.1.3', got 'inspect.lua 3.1.0'); restoring it passes.Happy to adjust if you'd rather not add the spec.