Forward response_id through StreamAccumulator to fix previous_response_id chaining - #14
Open
rustemmukhamadiev wants to merge 1 commit into
Open
rustemmukhamadiev wants to merge 1 commit into
rustemmukhamadiev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Saw the same fix already sitting in #12, but that PR's been open since
June and looks blocked on a bigger native-RubyLLM migration. Opening this
as a small standalone fix so it can land sooner — would love to see it
merged independently rather than wait on #12.
Bug
When using streaming (
chat.ask(message, &chunk_handler)), theresponse_idfromthe completed response never survives into the persisted message, so
previous_response_idchaining never engages on the next turn.Root cause
Streaming.build_chunkcorrectly attachesresponse_idto theresponse.completedchunk, butRubyLLM::StreamAccumulator#to_message(core gem) builds the final
Messagewithout it, andStreamAccumulatorExtensiononly forwardedbuilt_in_tool_eventsthrough the accumulator, not
response_id.Non-streaming (
chat.complete/chat.askwithout a block) is unaffected.Fix
Track
response_idthe same waybuilt_in_tool_eventsalready is:capture it in
add, apply it into_message.Verified locally: after the patch, a second streamed turn correctly
sends
previous_response_idand only the new message ininput,instead of resending the whole history.